-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[lexical-table] Support for vertical cell writing #6545
Draft
ivailop7
wants to merge
19
commits into
facebook:main
Choose a base branch
from
ivailop7:writing_mode
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+121
−2
Draft
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
0cbb683
Support for vertical cell writing
ivailop7 1dd6f3f
Support for vertical cell writing
ivailop7 87befee
Support for vertical cell writing
ivailop7 3c317cc
Support for vertical cell writing
ivailop7 7fb89b4
Tests
ivailop7 1f62e4f
Tests
ivailop7 91aabc2
Tests
ivailop7 c96524f
Tests
ivailop7 d2d9bc8
writingMode internals
ivailop7 561d214
writingMode internals
ivailop7 6e086f7
writingMode internals
ivailop7 63a753f
selection_fix
ivailop7 6990e86
remove child text node dep
ivailop7 9a022e6
update test
ivailop7 0439dc7
clean up
ivailop7 dbbee5c
clean up
ivailop7 bac145a
clean up 2
ivailop7 fa367df
tsdoc
ivailop7 4fd91d2
rename
ivailop7 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The source for
$getNodeTriplet
seems a little suspect since it effectively usesselection.anchor.getNode()
which could be possibly higher up in the table than inside of a cell? Seems kinda like a bad API to take a point or lexical node when we don't have an$isLexicalNode
orisPoint
guard for it to do that cleanly