Skip to content

Commit

Permalink
Support custom header_namespace in defs.bzl
Browse files Browse the repository at this point in the history
Summary:
Some of the targets to be BUCK-ified specified custom header
namespaces, and the compile failed.

Reviewed By: mzlee

Differential Revision: D67364855

fbshipit-source-id: 95431380f8b177aaad87de89f8f5c11f882682a0
  • Loading branch information
ckwalsh authored and facebook-github-bot committed Dec 18, 2024
1 parent b7449f8 commit 2449d5e
Showing 1 changed file with 9 additions and 3 deletions.
12 changes: 9 additions & 3 deletions quic/defs.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ def mvfst_cpp_library(
external_deps = (),
exported_external_deps = (),
modular_headers = None,
header_namespace = None,
**kwargs):
# Convert deps, exported_deps, and external_deps
if get_fbsource_cell() == "fbcode":
Expand All @@ -102,6 +103,7 @@ def mvfst_cpp_library(
external_deps = external_deps,
exported_external_deps = exported_external_deps,
modular_headers = modular_headers,
header_namespace = header_namespace,
**kwargs
)

Expand All @@ -122,7 +124,7 @@ def mvfst_cpp_library(
exported_deps = exported_deps,
exported_headers = headers,
headers = private_headers,
header_namespace = _compute_header_namespace(),
header_namespace = header_namespace or _compute_header_namespace(),
visibility = ["PUBLIC"],
**kwargs
)
Expand Down Expand Up @@ -206,6 +208,7 @@ def mvfst_cpp_test(
autodeps_skip = False,
deps = (),
external_deps = (),
header_namespace = None,
**kwargs):
# Convert deps and external_deps
if get_fbsource_cell() == "fbcode":
Expand All @@ -219,6 +222,7 @@ def mvfst_cpp_test(
autodeps_skip = True,
deps = deps,
external_deps = external_deps,
header_namespace = header_namespace,
**kwargs
)

Expand All @@ -233,7 +237,7 @@ def mvfst_cpp_test(
mvfst_cxx_test(
name,
deps = deps,
header_namespace = _compute_header_namespace(),
header_namespace = header_namespace or _compute_header_namespace(),
visibility = ["PUBLIC"],
**kwargs
)
Expand Down Expand Up @@ -264,6 +268,7 @@ def mvfst_cpp_binary(
autodeps_skip = False,
deps = (),
external_deps = (),
header_namespace = None,
**kwargs):
# Convert deps and external_deps
if get_fbsource_cell() == "fbcode":
Expand All @@ -277,6 +282,7 @@ def mvfst_cpp_binary(
autodeps_skip = True,
deps = deps,
external_deps = external_deps,
header_namespace = header_namespace,
**kwargs
)

Expand All @@ -291,7 +297,7 @@ def mvfst_cpp_binary(
mvfst_cxx_binary(
name,
deps = deps,
header_namespace = _compute_header_namespace(),
header_namespace = header_namespace or _compute_header_namespace(),
visibility = ["PUBLIC"],
**kwargs
)
Expand Down

0 comments on commit 2449d5e

Please # to comment.