Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Resource leak #116

Open
QiAnXinCodeSafe opened this issue Feb 6, 2020 · 0 comments
Open

Resource leak #116

QiAnXinCodeSafe opened this issue Feb 6, 2020 · 0 comments

Comments

@QiAnXinCodeSafe
Copy link

Stream is opened

openbmc/common/recipes-core/fw-util/files/tpm.cpp

Line 34 in 9d57980

fp = fopen(TPM_VERSION_LOCATION, "r");

Opened file never closed

openbmc/common/recipes-core/fw-util/files/tpm.cpp

Line 44 in 9d57980

return -1;

@leilanon leilanon mentioned this issue Apr 17, 2020
Closed
facebook-github-bot pushed a commit that referenced this issue May 26, 2020
@facebook-github-bot
fixes issue #110 (#119)
40bb49e 
Summary:
Fixes #110 Solution: Add print limitation.

#114 #116 #117  Seems to be false alarms.
However there is a possible memory leak in
https://github.com/facebook/openbmc/blob/de522bcdf9ea26e52a81b9a4a69326774bb87a07/common/recipes-core/fw-util/files/tpm2.cpp#L45
Opening pipeline should be closed at the end of process.
Pull Request resolved: #119

Reviewed By: benwei13

Pulled By: williamspatrick

fbshipit-source-id: 6f08ce26f4
facebook-github-bot pushed a commit that referenced this issue Dec 9, 2020
@joancaneus @facebook-github-bot
ELBERT: Use zeus (#116)
413b04b 
Summary:
ELBERT: Use zeus

Testing:
Build passed

NOTE: You need to update your cache built to get this to pass.

Pull Request resolved: facebookexternal/openbmc.arista#116

Reviewed By: tao-ren

fbshipit-source-id: 01d8af686e
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@QiAnXinCodeSafe