Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fabric: Using
#ifndef NDEBUG
instead of #ifdef DEBUG
Summary: Trivial. Apparently, `DEBUG` is non-standard feature and using `assert` with `DEBUG` is practically asking for bugs. So, if your `assert` relies on some variable which is only defined when `DEBUG` is set, it's easy to get invalid code because NDEBUG and DEBUG can be unsync. So, we have to use clunky double negative `#ifndef NDEBUG` everywhere where we used DEBUG. Reviewed By: JoshuaGross Differential Revision: D15031328 fbshipit-source-id: 036f573e68925741ca46384261885766c87db1e3
- Loading branch information