Skip to content

Commit

Permalink
Bump up the buffer size and show a warning if the trace might be trun…
Browse files Browse the repository at this point in the history
…cated

Summary: The current buffer size isn't enough even to capture a short TTI trace.

Reviewed By: mhorowitz

Differential Revision: D10112538

fbshipit-source-id: 266fa6ffa916049245b21d7725a364d75589c776
  • Loading branch information
alexeylang authored and facebook-github-bot committed Oct 2, 2018
1 parent ff084a4 commit 1fc8a46
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions React/CxxBridge/RCTCxxBridge.mm
Original file line number Diff line number Diff line change
Expand Up @@ -1261,6 +1261,10 @@ - (void)stopProfiling:(void (^)(NSData *))callback
NSData *logData = [log dataUsingEncoding:NSUTF8StringEncoding];
callback(logData);
#if WITH_FBSYSTRACE
if (![RCTFBSystrace verifyTraceSize:logData.length]) {
RCTLogWarn(@"Your FBSystrace trace might be truncated, try to bump up the buffer size"
" in RCTFBSystrace.m or capture a shorter trace");
}
[RCTFBSystrace unregisterCallbacks];
#endif
});
Expand Down

0 comments on commit 1fc8a46

Please # to comment.