RN: Fix Type for ReactNative.NativeComponent (2/2)

Reviewed By: TheSavior Differential Revision: D7984936 fbshipit-source-id: d0477c54420b49220e9529fa70c2b2babce0b409
facebook · May 13, 2018 · 7528636 · 7528636
1 parent de11ba2
commit 7528636
Show file tree

Hide file tree

Showing 6 changed files with 16 additions and 2 deletions.
diff --git a/Libraries/Components/Keyboard/KeyboardAvoidingView.js b/Libraries/Components/Keyboard/KeyboardAvoidingView.js
@@ -189,6 +189,7 @@ const KeyboardAvoidingView = ((createReactClass({
           heightStyle = {height: this.frame.height - bottomHeight, flex: 0};
         }
         return (
+          // $FlowFixMe - Typing ReactNativeComponent revealed errors
           <View
             ref={viewRef}
             style={[style, heightStyle]}
@@ -203,6 +204,7 @@ const KeyboardAvoidingView = ((createReactClass({
         const {contentContainerStyle} = this.props;
 
         return (
+          // $FlowFixMe - Typing ReactNativeComponent revealed errors
           <View
             ref={viewRef}
             style={style}
@@ -217,6 +219,7 @@ const KeyboardAvoidingView = ((createReactClass({
       case 'padding':
         const paddingStyle = {paddingBottom: bottomHeight};
         return (
+          // $FlowFixMe - Typing ReactNativeComponent revealed errors
           <View
             ref={viewRef}
             style={[style, paddingStyle]}
@@ -228,6 +231,7 @@ const KeyboardAvoidingView = ((createReactClass({
 
       default:
         return (
+          // $FlowFixMe - Typing ReactNativeComponent revealed errors
           <View
             ref={viewRef}
             onLayout={this._onLayout}

diff --git a/Libraries/Lists/VirtualizedList.js b/Libraries/Lists/VirtualizedList.js
@@ -757,7 +757,9 @@ class VirtualizedList extends React.PureComponent<Props, State> {
           cellKey={this._getCellKey() + '-header'}
           key="$header">
           <View onLayout={this._onLayoutHeader} style={inversionStyle}>
-            {element}
+            {
+              // $FlowFixMe - Typing ReactNativeComponent revealed errors
+              element}
           </View>
         </VirtualizedCellWrapper>,
       );
@@ -890,7 +892,9 @@ class VirtualizedList extends React.PureComponent<Props, State> {
           cellKey={this._getCellKey() + '-footer'}
           key="$footer">
           <View onLayout={this._onLayoutFooter} style={inversionStyle}>
-            {element}
+            {
+              // $FlowFixMe - Typing ReactNativeComponent revealed errors
+              element}
           </View>
         </VirtualizedCellWrapper>,
       );
@@ -1008,6 +1012,7 @@ class VirtualizedList extends React.PureComponent<Props, State> {
   _defaultRenderScrollComponent = props => {
     const onRefresh = props.onRefresh;
     if (this._isNestedWithSameOrientation()) {
+      // $FlowFixMe - Typing ReactNativeComponent revealed errors
       return <View {...props} />;
     } else if (onRefresh) {
       invariant(

diff --git a/Libraries/RCTTest/SnapshotViewIOS.ios.js b/Libraries/RCTTest/SnapshotViewIOS.ios.js
@@ -42,6 +42,7 @@ class SnapshotViewIOS extends React.Component<{
     const testIdentifier = this.props.testIdentifier || 'test';
     const onSnapshotReady = this.props.onSnapshotReady || this.onDefaultAction;
     return (
+      // $FlowFixMe - Typing ReactNativeComponent revealed errors
       <RCTSnapshot
         style={style.snapshot}
         {...this.props}

diff --git a/Libraries/ReactNative/AppContainer.js b/Libraries/ReactNative/AppContainer.js
@@ -102,6 +102,7 @@ class AppContainer extends React.Component<Props, State> {
         pointerEvents="box-none"
         style={styles.appContainer}
         ref={ref => {
+          // $FlowFixMe - Typing ReactNativeComponent revealed errors
           this._mainRef = ref;
         }}>
         {this.props.children}

diff --git a/Libraries/Text/Text.js b/Libraries/Text/Text.js
@@ -36,6 +36,7 @@ type ResponseHandlers = $ReadOnly<{|
 
 type Props = $ReadOnly<{
   ...TextProps,
+  // $FlowFixMe - Typing ReactNativeComponent revealed errors
   forwardedRef: ?React.Ref<NativeComponent<TextProps>>,
 }>;
 
@@ -139,6 +140,7 @@ class TouchableText extends React.Component<Props, State> {
       <TextAncestor.Consumer>
         {hasTextAncestor =>
           hasTextAncestor ? (
+            // $FlowFixMe - Typing ReactNativeComponent revealed errors
             <RCTVirtualText {...props} ref={props.forwardedRef} />
           ) : (
             <TextAncestor.Provider value={true}>

diff --git a/RNTester/js/RTLExample.js b/RNTester/js/RTLExample.js
@@ -484,6 +484,7 @@ class RTLExample extends React.Component<any, State> {
           <RNTesterBlock
             title={'Controlling Animation'}
             description={'Animation direction according to layout'}>
+            {/* $FlowFixMe - Typing ReactNativeComponent revealed errors */}
             <View Style={styles.view}>
               <AnimationBlock
                 onPress={this._linearTap}