Skip to content

Commit

Permalink
fix: iOS crash occurring when navigating to a new app screen with a d…
Browse files Browse the repository at this point in the history
…isplaying modal (#45313)

Summary:
Our app is using the react-native v0.74.2 with the `react-navigation` lib for screen navigation, we're facing an issue in the built iOS app that when we try to navigate to a new app screen with the `react-navigation`'s `reset` or `replace` method and meanwhile there's a react native modal displaying, then the iOS app always crashes.

I saw there is already a relevant [PR](#38491) and discussion targeting this issue, but I still think it would be better if this kind of crash can be suppressed in the framework level, currently I guess it's common in the iOS apps based on react native.

## Changelog:

[IOS] [FIXED] - app crash happening when navigate to a new app screen with a displaying modal

Pull Request resolved: #45313

Test Plan: More issue details and the reproduction steps can be found in this [PR](#38491) :)

Reviewed By: christophpurrer

Differential Revision: D61537167

Pulled By: cipolleschi

fbshipit-source-id: 3c0474d794b4216ebc073dd6558d2b6ae27492d2
  • Loading branch information
Zhi Zhou authored and blakef committed Sep 30, 2024
1 parent 893a4b3 commit 8ec6722
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions packages/react-native/React/Views/RCTModalHostView.m
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@ - (void)dismissModalViewController
if (_isPresented) {
[_delegate dismissModalHostView:self withViewController:_modalViewController animated:[self hasAnimationType]];
_isPresented = NO;
[self setVisible:NO];
}
}

Expand Down

0 comments on commit 8ec6722

Please # to comment.