-
Notifications
You must be signed in to change notification settings - Fork 24.7k
Remote Debug JS - works only DEV mode after 0.58 , but in 0.57 all good #23254
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Comments
Same |
Just leaving comment, it is also happening to me. |
I dont know, but i will try use clear project, without dependencies - today. But, if i think true, clear project also fail |
"dependencies": { |
This problem still persists in v0.59 |
Hello there 👋 this issue doesn't have a repro (which means, a Because of this, we are going to close this issue - but if a repro is shared, we are happy to reopen it 🤗 |
Reproducible Demo:On a freshly created project by
Errors I got, visible in chrome developer tool console:
@dulmandakh Hi, can you check this and consider reopening the issue? Thanks. |
@dulmandakh Can you reopen this issue? I am also having the same problem, and now there is a reproducible example (posted above). |
) Summary: Remote debugging stopped working (since 0.58, according to #23254). See #23254 (comment) for repro steps. The root cause is incorrect checks for Chrome debugging environment in `UIManager.js`. - In one place where sync function `lazilyLoadView` should be avoided, we effectively use `if (__DEV__ && !global.nativeCallSyncHook)` to check remote debugging, which misses ship flavor (i.e. `__DEV__` is false). - In another place where we want to pre-populate view managers' constants to avoid calling sync function `getConstantsForViewManager`, `if (__DEV__)` is used, also missing ship flavor. This PR fixes both checks, only using the absense of `global.nativeCallSyncHook` to determine remote debugging environments. ## Changelog [JavaScript] [Fixed] - Correctly bypass sync calls in UIManager during remote debugging Pull Request resolved: #25162 Differential Revision: D15692492 Pulled By: cpojer fbshipit-source-id: 173b688f140916b767fcdbbaaf68a5c303adbcd1
…ebook#25162) Summary: Remote debugging stopped working (since 0.58, according to facebook#23254). See facebook#23254 (comment) for repro steps. The root cause is incorrect checks for Chrome debugging environment in `UIManager.js`. - In one place where sync function `lazilyLoadView` should be avoided, we effectively use `if (__DEV__ && !global.nativeCallSyncHook)` to check remote debugging, which misses ship flavor (i.e. `__DEV__` is false). - In another place where we want to pre-populate view managers' constants to avoid calling sync function `getConstantsForViewManager`, `if (__DEV__)` is used, also missing ship flavor. This PR fixes both checks, only using the absense of `global.nativeCallSyncHook` to determine remote debugging environments. ## Changelog [JavaScript] [Fixed] - Correctly bypass sync calls in UIManager during remote debugging Pull Request resolved: facebook#25162 Differential Revision: D15692492 Pulled By: cpojer fbshipit-source-id: 173b688f140916b767fcdbbaaf68a5c303adbcd1
Environment
React Native Environment Info:
System:
OS: Windows 10
CPU: (4) x64 Intel(R) Core(TM) i5-4690K CPU @ 3.50GHz
Memory: 1.68 GB / 7.95 GB
Binaries:
npm: 6.7.0 - C:\Program Files\nodejs\npm.CMD
IDEs:
Android Studio: Version 3.3.0.0 AI-182.5107.16.33.5199772
Dependencies :
"dependencies": {
"react": "16.6.3",
"react-native": "0.58.3",
"react-native-gesture-handler": "^1.0.15",
"react-native-img-cache": "^1.6.0",
"react-native-section-list-get-item-layout": "^2.2.3",
"react-native-vector-icons": "^6.2.0",
"react-navigation": "^3.0.9",
"rn-fetch-blob": "^0.10.15"
},
Description
Remote Debug JS - works only DEV mode after 0.58 , but in 0.57 all good.
When starts it in Prod mode we have some errors
Cannot read property 'Constants' of null
Module AppRegistry is not a registered callable module (calling runApplication)
Reproducible Demo
The text was updated successfully, but these errors were encountered: