-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Start using Jest's "modern" fake-timer implementation. #29767
Comments
|
Ah, here's the missing environment info for the bot 🙂:
|
Hi @chrisbobbe thanks for the request & all the details. You opened a PR here: https://github.com/facebook/react-native/pull/29754/files Would this resolve the Jest issue, if merged in? |
This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
This issue was closed because it has been stalled for 7 days with no activity. |
Recent improvements have been made to Jest's implementation of fake timers, on an opt-in basis, with a plan to make them the default in the future: jestjs/jest#7776.
Some prep work has been done toward this (#29011), but I don't find an existing issue for the actual change.
Simply flipping the switch to the "modern" implementation gives several test failures, likely due to some combination of
I'm excited for
facebook/react-native
's own tests to be made more correct, but I particularly hope to draw attention to the fact that React Native apps can't currently use the new implementation (jestjs/jest#10221, #29303, #29754). This is a problem for apps that can't use the legacy implementation either, because of its issues (not havingDate.now()
faked is a big one).React Native version:
v0.61.5. (See #29767 (comment), below, for more environment info.)
The text was updated successfully, but these errors were encountered: