Skip to content

What does RCT stand for? #55

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
SanderSpies opened this issue Feb 8, 2015 · 3 comments
Closed

What does RCT stand for? #55

SanderSpies opened this issue Feb 8, 2015 · 3 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@SanderSpies
Copy link

No description provided.

@vjeux
Copy link
Contributor

vjeux commented Feb 8, 2015

ReaCT :)

@SanderSpies
Copy link
Author

Lol, I thought so - but it seemed too obvious :P.

@vjeux
Copy link
Contributor

vjeux commented Feb 8, 2015

We had RK before that stands for ReactKit but it turns out that some super popular iOS library already took this prefix and apparently 2 letters prefixes are reserved for Apple

@sebbarg sebbarg mentioned this issue May 18, 2017
Closed
facebook-github-bot pushed a commit that referenced this issue May 19, 2017
@sebbarg @facebook-github-bot
Run packager.sh using '.' instead of 'source'.
2f71270 
Summary:
'source' is not available in all shells on Linux (e.g. dash) and will silently fail launchPackager.command when called from runAndroid.js.

react-native run-android will thus silently fail to start the developement server ('JS server').

What existing problem does the pull request solve?

When running "react-native run-android" on the below reasonably vanilla Ubuntu system, the development server / packager script fails to start. It fails because sh defaults to dash (not bash) which doesn't know the command 'source'. dot (.) does the same as source, but works in all shells.

$ uname -a
Linux dallas 4.8.0-52-generic #55~16.04.1-Ubuntu SMP Fri Apr 28 14:36:29 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux

$ which sh
/bin/sh

$ readlink -f /bin/sh
/bin/dash

react-native-cli: 2.0.1
react-native: 0.44.0

$ ps aux | grep packager
(nothing)

ps aux | grep packager
sh /home/xxx/code/react-native/AwesomeProject/node_modules/react-native/packager/launchPackager.command
node /home/xxx/code/react-native/AwesomeProject/node_modules/react-native/packager/../local-cli/cli.js start
Closes #14040

Differential Revision: D5096298

Pulled By: hramos

fbshipit-source-id: 88466e802c9bc4358840391edb37e153f0a6b1f7
@facebook facebook locked as resolved and limited conversation to collaborators May 29, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 23, 2018
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees
No one assigned
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vjeux @SanderSpies @react-native-bot