Update Podfile documentation for RN >= 0.42.0 #12728
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please # at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions. |
facebook-github-bot
added
GH Review: review-needed
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
cc podspec master @alloy |
|
Yup, looks good. Thanks! |
docs/IntegrationWithExistingApps.md
Outdated
| @@ -248,6 +248,30 @@ end | |||
|
|
|||
| <block class="objc swift" /> | |||
|
|
|||
| > **Note:** From React Native `0.42.0` you have to explicitly include Yoga in your Podfile. Here is an example: | |||
There was a problem hiding this comment.
Remove this -- docs are versioned anyway.
docs/IntegrationWithExistingApps.md
Outdated
| 'RCTNetwork', | ||
| 'RCTWebSocket', | ||
| ] | ||
| # Explicitly include Yoga |
There was a problem hiding this comment.
Just add this to the existing podfile example
There was a problem hiding this comment.
The existing Podfile are extracted from projects NumberTileGame and swift-2048 which are not using react-native 0.42.0 so I didn't want to add confusion. That's why I added a new Podfile example block and added a Note to explain why.
There was a problem hiding this comment.
Just adding the line with a comment that says it only applies to RN >= 0.42.0 should be sufficient. A whole new example might add too much noise and cause the opposite effect of people glancing over it.
There was a problem hiding this comment.
done! So many commits for 4 new lines of documentation... 🙄😬😇
There was a problem hiding this comment.
Docs are hard, thanks for making the effort 👌
facebook-github-bot
added
GH Review: accepted
Import Started
|
@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
I've updated the documentation that gives an example of Podfile adding a note that from React Native 0.42.0, users have to explicitly include Yoga in their Podfile.
I didn't want to modify existing
Podfilefrom this documentation because they refer toPodfilefrom existing projects that do not use RN 0.42.0. So I just added a note and an example to explain how to include Yoga.This PR is to fix the following issue: #12670