-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[createReactClass] Remove createReactClass from ProgressBarAndroidExample #21874
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code analysis results:
eslint
found some issues.
}; | ||
|
||
class MovingBar extends React.Component<MovingBarProps, MovingBarState> { | ||
_intervalID: (null: ?IntervalID); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
null: Parsing error: Unexpected token, expected ")"
27 |
28 | class MovingBar extends React.Component<MovingBarProps, MovingBarState> {
29 | _intervalID: (null: ?IntervalID);
| ^
30 |
31 | state = {
32 | progress: 0,
It looks like there are flow errors: |
I fixed the ESLint issues. Besides I don't have any Flow errors locally, is the config different ? |
You need to run with the Android config to check
|
@TheSavior I updated Props to fit ProgressBarAndroid component. I also exported its props to make it handier for me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 🧐
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RSNara has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: Related to #21581 This PR was already opened here facebook/react-native#21600 but seems to be inactive. Remove createReactClass from ProgressBarAndroidExample. - `yarn run flow` && `yarn run flow-check-android` succeed. - RNTester app ProgressBarAndroidExample on Android. [GENERAL] [ENHANCEMENT] [ProgressBarAndroidExample.android.js] - rm createReactClass Pull Request resolved: facebook/react-native#21874 Reviewed By: TheSavior Differential Revision: D12827689 Pulled By: RSNara fbshipit-source-id: 46c70ea67dddf5d928fe936a28ef4a0a929d127f
Summary: Related to facebook#21581 This PR was already opened here facebook#21600 but seems to be inactive. Remove createReactClass from ProgressBarAndroidExample. - `yarn run flow` && `yarn run flow-check-android` succeed. - RNTester app ProgressBarAndroidExample on Android. [GENERAL] [ENHANCEMENT] [ProgressBarAndroidExample.android.js] - rm createReactClass Pull Request resolved: facebook#21874 Reviewed By: TheSavior Differential Revision: D12827689 Pulled By: RSNara fbshipit-source-id: 46c70ea67dddf5d928fe936a28ef4a0a929d127f
Related to #21581
This PR was already opened here #21600 but seems to be inactive.
Remove createReactClass from ProgressBarAndroidExample.
Test Plan:
yarn run flow
&&yarn run flow-check-android
succeed.Release Notes:
[GENERAL] [ENHANCEMENT] [ProgressBarAndroidExample.android.js] - rm createReactClass