Extract out CLI #22337
Extract out CLI #22337
Conversation
facebook-github-bot
added
the
CLA Signed
|
Few questions:
Action items: Right now, the The changes are not really relevant to this PR (from the stability perspective). My idea is to merge this PR and once it happens, I will send another one the same day to bump |
There was a problem hiding this comment.
@axe-fb has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
| @@ -142,9 +142,6 @@ | |||
| "build-ios-e2e": "detox build -c ios.sim.release", | |||
| "test-ios-e2e": "detox test -c ios.sim.release --cleanup" | |||
| }, | |||
| "bin": { | |||
There was a problem hiding this comment.
Why don't we want this anymore? It seems like it is there to catch people from making mistakes. Is that mistake not possible anymore? Or we just think it isn't a big deal anymore?
There was a problem hiding this comment.
We have kept this behaviour, but made react-native-local-cli to have "bin" property instead. So just declaring in a different npm module (since React Native itself doesn't have an executable anymore)
Summary: Continuation of facebook/react-native#22174 with an exception that `local-cli` folder is left in React Native repository to keep Facebook internal and React Native calls still working. Separate strategy should be developed to remove all uses of `local-cli` in favor of dedicated utilities. Pull Request resolved: facebook/react-native#22337 Reviewed By: TheSavior Differential Revision: D13172898 Pulled By: cpojer fbshipit-source-id: 0217867f9944648307475ebe629eb729da7bfaaf
Continuation of #22174 with an exception that
local-clifolder is left in React Native repository to keep Facebook internal and React Native calls still working.Separate strategy should be developed to remove all uses of
local-cliin favor of dedicated utilities.