[npm] Update to stacktrace-parser@0.1.3 and ws@0.8.0 to satisfy io.js 3 / Node 4 #2398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
GH Review: review-needed
CLA Signed
ide
force-pushed
the
iojs-3-deps
branch
5 times, most recently
from
ab1cbff to
c8b06f7
Compare
|
👍 👍 |
|
Node 4.0 is expected to ship next week Sep. 3 or Sep. 7, so it would be timely to get this in soon. |
… 3 / Node 4 The previous version of stacktrace-parser 0.1.2 had an line in its package.json file that required Node <= 2.x. That line was removed, so it no longer warns on io.js 3.x or Node 4.x. Similarly, ws 0.8.0 was published with support for the new V8, so it compiles with io.js 3.x and therefore should work with Node 4.x. Updated the Travis file as well to run on io.js 3.x. Test Plan: ``` $ nvm use iojs-v3 Now using io.js v3.1.0 (npm v2.13.3) $ npm i <no compiler errors> ```
|
Updated this to use pinned versions instead of the npm caret^ |
|
@facebook-github-bot import |
tadeuzagallo
added a commit
that referenced
this pull request
Sep 2, 2015
[npm] Update to stacktrace-parser@0.1.3 and ws@0.8.0 to satisfy io.js 3 / Node 4
sahrens
pushed a commit
to sahrens/react-native
that referenced
this pull request
Sep 3, 2015
… 3 / Node 4 Summary: The previous version of stacktrace-parser 0.1.2 had an line in its package.json file that required Node <= 2.x. That line was removed, so it no longer warns on io.js 3.x or Node 4.x. Similarly, ws 0.8.0 was published with support for the new V8, so it compiles with io.js 3.x and therefore should work with Node 4.x. Updated the Travis file as well to run on io.js 3.x. Fixes facebook#2258, facebook#2455 Closes facebook#2398 Github Author: James Ide <ide@jameside.com>
ide
added a commit
that referenced
this pull request
Sep 8, 2015
… 3 / Node 4 Summary: The previous version of stacktrace-parser 0.1.2 had an line in its package.json file that required Node <= 2.x. That line was removed, so it no longer warns on io.js 3.x or Node 4.x. Similarly, ws 0.8.0 was published with support for the new V8, so it compiles with io.js 3.x and therefore should work with Node 4.x. Updated the Travis file as well to run on io.js 3.x. Fixes #2258, #2455 Closes #2398 Github Author: James Ide <ide@jameside.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous version of stacktrace-parser 0.1.2 had an line in its package.json file that required Node <= 2.x. That line was removed, so it no longer warns on io.js 3.x or Node 4.x.
Similarly, ws 0.8.0 was published with support for the new V8, so it compiles with io.js 3.x and therefore should work with Node 4.x.
Updated the Travis file as well to run on io.js 3.x.
Fixes #2258, #2455
Test Plan: