[Node 4] Update .travis.yml to install Node 4.x #2548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
ide
force-pushed
the
node-convergence-tests
branch
2 times, most recently
from
44e5506 to
b5efad9
Compare
|
Can you remove the change to package.json? I'll update jest to 0.5.5 and then I can merge your PR. |
Jest 0.5.2 ships with a fix for bound functions, which RN exercises. And with this Travis change, the automated tests will install Node 4.x with nvm before running. Test Plan:`nvm use 4 && npm i && npm test` See if Travis tests pass.
ide
force-pushed
the
node-convergence-tests
branch
from
b5efad9 to
fb59425
Compare
|
@cpojer -- just the travis change now. |
cpojer
added a commit
that referenced
this pull request
Sep 16, 2015
[Node 4] Update .travis.yml to install Node 4.x
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The automated tests will install Node 4.x with nvm before running.
Test Plan: See if Travis tests pass.