Support PlatformColor in borderColor on Android #33544
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Base commit: 16397e0 |
danilobuerger
force-pushed
the
borderplatformcolor
branch
from
7ac2d4c to
9d31e75
Compare
Base commit: 16397e0 |
|
@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Hi @NickGerleman, thanks for importing the PR. Is there anything I can do about the Internal Linter warning? |
|
This pull request was successfully merged by @danilobuerger in 2d5db28. When will my fix make it into a release? | Upcoming Releases |
dmytrorykun
pushed a commit
that referenced
this pull request
Sep 14, 2022
Summary: PlatformColor should work on all *color style attributes on all platform. Partially fixes #32942 ## Changelog [Android] [Fixed] - Support PlatformColor in borderColor Pull Request resolved: #33544 Test Plan: Open rn tester (USE_FABRIC=false) platform color api examples. Without the changes to ViewProps.java, it will error out. Reviewed By: lunaleaps Differential Revision: D39413519 Pulled By: NickGerleman fbshipit-source-id: 58962ba2956aa3df45144108eec194aedf23886b
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: PlatformColor should work on all *color style attributes on all platform. Partially fixes facebook#32942 ## Changelog [Android] [Fixed] - Support PlatformColor in borderColor Pull Request resolved: facebook#33544 Test Plan: Open rn tester (USE_FABRIC=false) platform color api examples. Without the changes to ViewProps.java, it will error out. Reviewed By: lunaleaps Differential Revision: D39413519 Pulled By: NickGerleman fbshipit-source-id: 58962ba2956aa3df45144108eec194aedf23886b
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PlatformColor should work on all *color style attributes on all platform.
Partially fixes #32942
Changelog
[Android] [Fixed] - Support PlatformColor in borderColor
Test Plan
Open rn tester (USE_FABRIC=false) platform color api examples. Without the changes to ViewProps.java, it will error out.