Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix Circle CI test_ios_template #33761

Closed
wants to merge 1 commit into from

Conversation

dmytrorykun
Copy link
Contributor

@dmytrorykun dmytrorykun commented May 4, 2022

Summary:
Changelog:
[General][Fixed] - Add 'mkdirp' as a direct dependency to 'react-native' instead of assuming it being a transitive dependency of some other module.

Differential Revision: D36138320

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels May 4, 2022
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D36138320

@analysis-bot
Copy link

analysis-bot commented May 5, 2022

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,779,055 +0
android hermes armeabi-v7a 7,184,121 +0
android hermes x86 8,087,962 +0
android hermes x86_64 8,068,669 +0
android jsc arm64-v8a 9,653,396 +0
android jsc armeabi-v7a 8,427,173 +0
android jsc x86 9,603,027 +0
android jsc x86_64 10,200,677 +0

Base commit: 018d5cf
Branch: main

@analysis-bot
Copy link

analysis-bot commented May 5, 2022

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 018d5cf
Branch: main

Summary:
Pull Request resolved: facebook#33761

Changelog:
[General][Fixed] - Add 'mkdirp' as a direct dependency to 'react-native' instead of assuming it being a transitive dependency of some other module.

Reviewed By: cortinico

Differential Revision: D36138320

fbshipit-source-id: 2588b1cfa2804c7c594647d6f8962653ad471a5a
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D36138320

@dmytrorykun dmytrorykun requested a review from hramos as a code owner May 5, 2022 15:00
@pull-bot
Copy link

pull-bot commented May 5, 2022

Warnings
⚠️ 🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against 4b531c5

@matinzd
Copy link
Contributor

matinzd commented May 7, 2022

@hramos @cortinico
I think this can be merged safely. CI still failing on the main branch.

@cortinico
Copy link
Contributor

@hramos @cortinico
I think this can be merged safely. CI still failing on the main branch.

That's on @dmitryrykun to drive to land 👍

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by Dmitry Rykun in 94341f0.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label May 8, 2022
fortmarek pushed a commit that referenced this pull request May 20, 2022
Summary:
Pull Request resolved: #33761

Changelog:
[General][Fixed] - Add 'mkdirp' as a direct dependency to 'react-native' instead of assuming it being a transitive dependency of some other module.

Reviewed By: cortinico, cipolleschi

Differential Revision: D36138320

fbshipit-source-id: b2421aa6b22fca0b813bbb5bb0c7213540ca578d
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants