-
Notifications
You must be signed in to change notification settings - Fork 24.5k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix Circle CI test_ios_template #33761
Conversation
This pull request was exported from Phabricator. Differential Revision: D36138320 |
e81a130
to
2e55b1d
Compare
Base commit: 018d5cf |
Base commit: 018d5cf |
Summary: Pull Request resolved: facebook#33761 Changelog: [General][Fixed] - Add 'mkdirp' as a direct dependency to 'react-native' instead of assuming it being a transitive dependency of some other module. Reviewed By: cortinico Differential Revision: D36138320 fbshipit-source-id: 2588b1cfa2804c7c594647d6f8962653ad471a5a
This pull request was exported from Phabricator. Differential Revision: D36138320 |
2e55b1d
to
4b531c5
Compare
@hramos @cortinico |
That's on @dmitryrykun to drive to land 👍 |
This pull request was successfully merged by Dmitry Rykun in 94341f0. When will my fix make it into a release? | Upcoming Releases |
Summary: Pull Request resolved: #33761 Changelog: [General][Fixed] - Add 'mkdirp' as a direct dependency to 'react-native' instead of assuming it being a transitive dependency of some other module. Reviewed By: cortinico, cipolleschi Differential Revision: D36138320 fbshipit-source-id: b2421aa6b22fca0b813bbb5bb0c7213540ca578d
Summary:
Changelog:
[General][Fixed] - Add 'mkdirp' as a direct dependency to 'react-native' instead of assuming it being a transitive dependency of some other module.
Differential Revision: D36138320