Fix downloading prebuilt hermes from the Github release

[fortmarek]

Summary

This:

source[:http] = `https://github.com/facebook/react-native/releases/download/v#{version}/hermes-runtime-darwin-v#{version}.tar.gz`

currently fails with the following error:

[!] Failed to load 'hermes-engine' podspec: 
[!] Invalid `hermes-engine.podspec` file: No such file or directory - https://github.com/facebook/react-native/releases/download/v0.69.0-rc.4/hermes-runtime-darwin-v0.69.0-rc.4.tar.gz.

For some reasons, the string with backticks is treated differently than with double quotes since this works:

source[:http] = "https://github.com/facebook/react-native/releases/download/v#{version}/hermes-runtime-darwin-v#{version}.tar.gz"

Changelog

[Internal] - Fix downloading prebuilt hermes from the Github release

Test Plan

• npx react-native init RN069RC4 --version 0.69.0-rc.4
• in the created project, run pod install with hermes enabled
• run git init && git add . && git commit -m "Initial commit" && git remote add origin https://github.com/fortmarek/some-fake-repository (this is necessary due to an unrelated bug in the RC4)
• observe error
• update node_modules/react-native/sdks/hermes-engine/hermes-engine.podspec with the change from this commit
• run pod install
• 🎉

[cortinico]

cc @hramos @cipolleschi for visibility

[facebook-github-bot]

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	7,788,244	+0
android	hermes	armeabi-v7a	7,191,825	+0
android	hermes	x86	8,099,598	+0
android	hermes	x86_64	8,077,103	+0
android	jsc	arm64-v8a	9,656,305	+0
android	jsc	armeabi-v7a	8,428,809	+0
android	jsc	x86	9,608,478	+0
android	jsc	x86_64	10,203,027	+0

Base commit: f4123b0
Branch: main

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: f4123b0
Branch: main

[react-native-bot]

This pull request was successfully merged by @fortmarek in 91452fc.

^{When will my fix make it into a release? | Upcoming Releases}

[leotm]

saw the nightly was yday and rc5's bit away, so went for the patch

updating .../hermes-engine.podspec kept reverting each pod install on Yarn 3

but was easy enough

• yarn patch react-native
• update .../sdks/hermes-engine/hermes-engine.podspec
• yarn patch-commit -s ...
• rm -rf node_modules
• yarn

before

after

thx again @fortmarek

btw i presume these backticks remain fine

react-native/sdks/hermes-engine/hermes-engine.podspec

Line 22 in 91452fc

source[:commit] = `git ls-remote https://github.com/facebook/hermes main | cut -f 1`.strip

[leotm]

just for completeness

react-native/sdks/hermes-engine/hermes-engine.podspec

Line 41 in 91452fc

spec.platforms = { :osx => "10.13", :ios => "11.0" }

-  spec.platforms   = { :osx => "10.13", :ios => "11.0" } 
+ spec.platforms   = { :osx => "10.13", :ios => "12.4" } 

think we need to deprecate iOS/tvOS SDK 11.0 support, now that 12.4+ is required

[leotm]

ref: reactwg/react-native-releases#21 (comment) (result of the patch above on rc4, aka rc5)