Update the New App template to reduce the amount of C++ code in user space #34666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D39381762 |
Base commit: 9929ead |
Base commit: 56c28f3 |
|
This pull request was exported from Phabricator. Differential Revision: D39381762 |
cortinico
force-pushed
the
export-D39381762
branch
from
185aad7 to
6c8b754
Compare
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Sep 12, 2022
…space (facebook#34666) Summary: Pull Request resolved: facebook#34666 This diff updates the new app template and reduces the amount of C++ code in user space. From now on users will have to only: 1. Create a CMakeLists.txt file 2. Create an OnLoad.cpp file with the Modules/Components they want to provide. Changelog: [Android] [Changed] - Update the template to Reduce the amount of C++ code in user space for New Architecture Reviewed By: cipolleschi Differential Revision: D39381762 fbshipit-source-id: 8e800a0bfc12d1b635fb625bb59589f969c29d94
Summary: This diff reduces the amount of C++ code in user space by: - Moving all the C++ implementation of the .defaults package inside a `react_newarchdefaults` shared library - Exposing only the entrypoint logic inside the RN-Tester's `OnLoad.cpp` file. Changelog: [Android] [Changed] - Reduce the amount of C++ code in user space for New Architecture Differential Revision: D39381820 fbshipit-source-id: 42c39ccdf9c02f8306d9e82e4072506ef4353105
…space (facebook#34666) Summary: Pull Request resolved: facebook#34666 This diff updates the new app template and reduces the amount of C++ code in user space. From now on users will have to only: 1. Create a CMakeLists.txt file 2. Create an OnLoad.cpp file with the Modules/Components they want to provide. Changelog: [Android] [Changed] - Update the template to Reduce the amount of C++ code in user space for New Architecture Reviewed By: cipolleschi Differential Revision: D39381762 fbshipit-source-id: 18f927ddf57a5c5fe7270113b014026f963c62e4
|
This pull request was exported from Phabricator. Differential Revision: D39381762 |
cortinico
force-pushed
the
export-D39381762
branch
from
6c8b754 to
797f1e7
Compare
|
This pull request was successfully merged by @cortinico in b0aba1b. When will my fix make it into a release? | Upcoming Releases |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
…space (facebook#34666) Summary: Pull Request resolved: facebook#34666 This diff updates the new app template and reduces the amount of C++ code in user space. From now on users will have to only: 1. Create a CMakeLists.txt file 2. Create an OnLoad.cpp file with the Modules/Components they want to provide. Changelog: [Android] [Changed] - Update the template to Reduce the amount of C++ code in user space for New Architecture Reviewed By: cipolleschi Differential Revision: D39381762 fbshipit-source-id: 7309b6c61ba9ddd8856cb4aaa6d923ddd816741c
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff updates the new app template and reduces the amount of C++ code in user space.
From now on users will have to only:
Changelog:
[Android] [Changed] - Update the template to Reduce the amount of C++ code in user space for New Architecture
Reviewed By: cipolleschi
Differential Revision: D39381762