Use the right logic to decide when we build Hermes from source

[cipolleschi]

Summary

This PR backports the changes in 0.71 to apply the same logic to decide when we have to build Hermes from source in both the hermes-engine.podspec
and in the react_native_pods.rb script.

Changelog

[iOS] [Fixed] - Use the right logic to decide when we have to build from source

Test Plan

Working on RC2

[facebook-github-bot]

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	7,103,561	+0
android	hermes	armeabi-v7a	6,471,886	+0
android	hermes	x86	7,521,203	+0
android	hermes	x86_64	7,380,081	+0
android	jsc	arm64-v8a	8,968,399	+0
android	jsc	armeabi-v7a	7,699,505	+0
android	jsc	x86	9,030,706	+0
android	jsc	x86_64	9,508,749	+0

Base commit: c4959b9
Branch: main

[dmytrorykun]

is_building_hermes_from_source in this PR looks different from the on in 49c0267

[cipolleschi]

PR updated. The

    if ENV['HERMES_ENGINE_TARBALL_PATH'] != nil
        return false
    end

Is required to avoid to build from source even when the tarball is passed.

I had a merge conflict which has been resolved wrongly, applying the wrong return statement. Luckily, the ruby tests were failing! :D

Thanks for spotting this!

[facebook-github-bot]

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: c4959b9
Branch: main

[react-native-bot]

This pull request was successfully merged by @cipolleschi in 67d0264.

^{When will my fix make it into a release? | Upcoming Releases}