fix(e2e script): backport from 71 fixes to the E2E script #35477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
kelset
changed the title
|
@jacdebug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Base commit: e680018 |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
…5477) Summary: Because the /scripts folder for some reason is not typechecked at all, some changes broke the script and went undetected until we tried running it. This is a backport of those fixes: * facebook@67c373f * facebook@6107793 * facebook@6107793 Also, it's backporting an improvement to the e2e local script clean to remove the hermes-engine pod cache which has been proven annoyingly in the way while testing: * facebook@9979e38 ## Changelog [Internal] [Fixed] - Fix e2e script not working and augment clean script Pull Request resolved: facebook#35477 Test Plan: Works on 0.71 ;) Reviewed By: dmytrorykun Differential Revision: D41530272 Pulled By: jacdebug fbshipit-source-id: d45650d919ad5ef08438b307f122817d72771f46
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Because the /scripts folder for some reason is not typechecked at all, some changes broke the script and went undetected until we tried running it. This is a backport of those fixes:
Also, it's backporting an improvement to the e2e local script clean to remove the hermes-engine pod cache which has been proven annoyingly in the way while testing:
Changelog
[Internal] [Fixed] - Fix e2e script not working and augment clean script
Test Plan
Works on 0.71 ;)