Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[iOS] Fix ScrollView automaticallyAdjustKeyboardInsets not resetting when Prefer Cross-Fade Transitions is enabled #35933

Closed
wants to merge 2 commits into from
Closed

[iOS] Fix ScrollView automaticallyAdjustKeyboardInsets not resetting when Prefer Cross-Fade Transitions is enabled #35933

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3107bc8
[iOS] Fix ScrollView automaticallyAdjustKeyboardInsets not resetting …
grgmo Jan 23, 2023
2f7b3b8
Merge branch 'facebook:main' into fix_scrollview_reduce_motion_cross_…
grgmo Jan 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions React/Views/ScrollView/RCTScrollView.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,6 +331,16 @@ - (void)_keyboardWillChangeFrame:(NSNotification *)notification
newContentOffset.y -= contentDiff;
}

if (@available(iOS 14.0, *)) {
// On iOS when Prefer Cross-Fade Transitions is enabled, the keyboard position
// & height is reported differently (0 instead of Y position value matching height of frame)
// Fixes similar issue we saw with https://github.com/facebook/react-native/pull/34503
if (UIAccessibilityPrefersCrossFadeTransitions() && endFrame.size.height == 0) {
newContentOffset.y = 0;
newEdgeInsets.bottom = 0;
}
}

[UIView animateWithDuration:duration
delay:0.0
options:animationOptionsWithCurve(curve)
Expand Down