fix: role="searchbox" should assign "SearchField" trait on iOS
#39314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
@dmytrorykun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
mdjastrzebski
changed the title
role="searchbox" should assign "SearchField" trait on iOS
|
@dmytrorykun merged this pull request in 2749fbc. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Experimenting with Accessibility Inspector on iOS I've discovered that while when assigning
accessibilityRole="searchbox"to a text input results in "Traits" reporting "Search Field" trait. However, when using ARIA-compatiblerole="search"such trait is not assigned, and text input will have an empty trait.Afaiu this is incorrect as using
role="search"andaccessibilityRole="searchbox"should equivalent effect.Changelog:
[iOS] [Fixed] - Setting
role="searchbox"assigns "Search Field" accessibility trait to a viewTest Plan:
No UI changes, it affects only accessibility.