Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[LOCAL] Copy hermes ruby files to hermes folder in local E2E test #39577

Conversation

cipolleschi
Copy link
Contributor

@cipolleschi cipolleschi commented Sep 21, 2023

Summary:

When testing another feature, I realized that we were not copying the hermes-engine.podspec and the hermes-utils.rb files from the hermes-engine folder to the hermes one.

This means that the script was building Hermes for local testing using an outdated hermes-engine.podspec that is downloaded from the hermes repo.

Changelog:

[INTERNAL] - Copy over the hermes-engine.podspec and hermes-utils.rb files in the test-e2e-local script

Test Plan:

Tested locally

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 21, 2023
@cipolleschi cipolleschi changed the base branch from main to 0.71-stable September 21, 2023 10:59
@cipolleschi cipolleschi marked this pull request as ready for review September 21, 2023 10:59
@github-actions
Copy link

Warnings
⚠️ One hour and a half have passed and the E2E jobs haven't finished yet.

Generated by 🚫 dangerJS against 252b05b

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner Pick Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants