Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[RN][CI] Fix e2e test setup #42087

Merged
merged 1 commit into from
Dec 28, 2023
Merged

[RN][CI] Fix e2e test setup #42087

merged 1 commit into from
Dec 28, 2023

Conversation

cipolleschi
Copy link
Contributor

@cipolleschi cipolleschi commented Dec 28, 2023 •
edited
Loading

Summary:

test_e2e_ios is failing because the default bundler version that is installed in CI does not support Ruby 2 anymore.

This PR ports the same fix @fortmarek did for 0.72 in #41989

Changelog:

[Internal] - Fix test_e2e_ios in CI

Test Plan:

CircleCI is green

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Dec 28, 2023
@cipolleschi cipolleschi changed the base branch from main to 0.73-stable December 28, 2023 08:56
@cipolleschi cipolleschi marked this pull request as ready for review December 28, 2023 08:57
@cipolleschi cipolleschi force-pushed the cipolleschi/fix-ios-ci branch from 75b5a2b to 4e6b166 Compare December 28, 2023 08:57
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,514,882 -8,063,060
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 9,753,036 -10,202,003
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: b507e11
Branch: main

@github-actions GitHub Actions
Copy link

Warnings
⚠️

Can't find the E2E test log for ci/circleci: test_e2e_ios. Job link

Generated by 🚫 dangerJS against 4e6b166

@huntie
Copy link
Member

huntie commented Dec 28, 2023

Merging, and will update Podfile.lock to hopefully make the next build green.

@huntie huntie merged commit 5061d45 into 0.73-stable Dec 28, 2023
@huntie huntie deleted the cipolleschi/fix-ios-ci branch December 28, 2023 10:07
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Titozzz Titozzz Titozzz approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner Pick Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cipolleschi @analysis-bot @huntie @Titozzz @facebook-github-bot