Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[RN][iOS] Disable Bitcode for Hermes #42142

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

cipolleschi
Copy link
Contributor

@cipolleschi cipolleschi commented Jan 4, 2024

Summary:

Backports the commit de6bfec to 0.72.

Disabling the Bitcode has several benefits:

  1. Downloading artifacts while testing will take much less time
  2. Creating a new app will take less time
  3. The Space occupied on Dev's machine is sensibly smaller

Community testing reported that the tarball size get reduced from ~500 Mb to ~25 Mb, a x20 reduction

Changelog:

[iOS][Changed] - Disabled bitcode for Hermes prebuilts

Test Plan:

Wait for CircleCI...

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 4, 2024
@cipolleschi cipolleschi changed the base branch from main to 0.72-stable January 4, 2024 14:26
@cipolleschi cipolleschi marked this pull request as ready for review January 4, 2024 14:29
@cipolleschi cipolleschi changed the title cipolleschi/disable bitcode hermes [RN][iOS] Disable Bitcode for Hermes Jan 4, 2024
@huntie huntie merged commit 89ef9cb into 0.72-stable Jan 15, 2024
62 of 68 checks passed
@huntie huntie deleted the cipolleschi/disable_bitcode_hermes branch January 15, 2024 15:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner Pick Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants