[#42164] Patches with-environment.sh script
#42184
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
facebook-github-bot
added
the
Shared with Meta
Closed
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Base commit: 8c14997 |
|
This pull request was successfully merged by @birdofpreyru in c684f9f. When will my fix make it into a release? | Upcoming Releases |
|
@cipolleschi merged this pull request in c684f9f. |
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
Summary: Closes facebook#42164 ## Changelog: [IOS] [FIXED] - Fixes `with-environment.sh` script for the case when Node can't be found prior to loading `.xcode.env` Pull Request resolved: facebook#42184 Test Plan: This is a trivial update, no need for much testing. Reviewed By: cortinico Differential Revision: D52602653 Pulled By: cipolleschi fbshipit-source-id: 0881456bf165d895252ae38cb7c7aee945cfaf52
gokul1099
pushed a commit
to gokul1099/react-native-visionos
that referenced
this pull request
Jan 17, 2024
Summary: Closes facebook#42164 ## Changelog: [IOS] [FIXED] - Fixes `with-environment.sh` script for the case when Node can't be found prior to loading `.xcode.env` Pull Request resolved: facebook#42184 Test Plan: This is a trivial update, no need for much testing. Reviewed By: cortinico Differential Revision: D52602653 Pulled By: cipolleschi fbshipit-source-id: 0881456bf165d895252ae38cb7c7aee945cfaf52
lunaleaps
pushed a commit
that referenced
this pull request
Feb 19, 2024
Summary: Closes #42164 ## Changelog: [IOS] [FIXED] - Fixes `with-environment.sh` script for the case when Node can't be found prior to loading `.xcode.env` Pull Request resolved: #42184 Test Plan: This is a trivial update, no need for much testing. Reviewed By: cortinico Differential Revision: D52602653 Pulled By: cipolleschi fbshipit-source-id: 0881456bf165d895252ae38cb7c7aee945cfaf52
This was referenced Feb 29, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Closes #42164
Changelog:
[IOS] [FIXED] - Fixes
with-environment.shscript for the case when Node can't be found prior to loading.xcode.envTest Plan:
This is a trivial update, no need for much testing.