Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Cherry-picking 'Call super.onRequestPermissionsResult in ReactActivity (#42478)' onto 0.71 #42662

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

cortinico
Copy link
Contributor

Summary:

I'm cherry-picking 96ed119 on the release branch for 0.71.

This change allows activities to handle onRequestPermissionsResult callbacks (eg: registerForActivityResult)

Fixes #42403

Changelog:

[Android][Changed] - Call super.onRequestPermissionsResult in ReactActivity's onRequestPermissionsResult()

Pull Request resolved: #42478

Test Plan:
Without super.onRequestPermissionsResult() call

before

With super.onRequestPermissionsResult() call

after

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 25, 2024
@cortinico
Copy link
Contributor Author

cc @hurali97

@hurali97 hurali97 merged commit c6b6132 into 0.71-stable Jan 26, 2024
46 of 52 checks passed
@cortinico cortinico deleted the nc/cp-96ed1190 branch June 10, 2024 13:07
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants