-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[RN][Hermes] Fore Hermes versions for slices through env var #45840
Conversation
Base commit: fcd526d |
0f439f7
to
4852ed9
Compare
3b56bb6
to
d193ae2
Compare
d193ae2
to
0009a96
Compare
Can someone please merge this? Thanks in advance |
Which release includes this fix? Can someone please point me to it if published? Thanks |
Hello, look like in 0.74.5 → https://github.com/facebook/react-native/releases/tag/v0.74.5 |
Great, thanks a bunch 🤝 |
Summary:
We were building Hermes slices without passing the right version, as the mechanism that reads from the podspec got broken somehow.
This fix forces the versions for 0.74.
Changelog:
[General][Fixed] - Pass the right Apple system fvarsions to Hermes
Test Plan:
Wait for CircleCI to be green
Download the artifact
Verify that versions are set up correctly.