Breaking: Set "enableBackgroundStyleApplicator" by default #45866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D60365677 |
…45866) Summary: Pull Request resolved: facebook#45866 This turns on enableBackgroundStyleApplicator() by default, which will get us more screenshot tests over existing apps, and let us add new screenshot tests for box-shadow against stock RNTester. This is a breaking change, for the small number of libraries which use CSSBackgroundDrawable/ReactViewBackgroundDrawable off of a view directly, for setting or accessing styles (this was already unreliably), along with libraries which read `mBorderRadius` from views using reflection. This is more or less confined to Reanimated, react-native-navigation, and one internal library. Users who want to access or mutate background styles should use the public `BackgroundStyleApplicator` instead. Changelog: [Android][Breaking] - Set "enableBackgroundStyleApplicator" by default Differential Revision: D60365677
|
This pull request was exported from Phabricator. Differential Revision: D60365677 |
NickGerleman
force-pushed
the
export-D60365677
branch
from
2c26eec to
b5d951e
Compare
|
This pull request has been merged in 5f14963. |
|
This pull request was successfully merged by @NickGerleman in 5f14963 When will my fix make it into a release? | How to file a pick request? |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This turns on enableBackgroundStyleApplicator() by default, which will get us more screenshot tests over existing apps, and let us add new screenshot tests for box-shadow against stock RNTester.
This is a breaking change, for the small number of libraries which use CSSBackgroundDrawable/ReactViewBackgroundDrawable off of a view directly, for setting or accessing styles (this was already unreliably), along with libraries which read
mBorderRadiusfrom views using reflection. This is more or less confined to Reanimated, react-native-navigation, and one internal library.Users who want to access or mutate background styles should use the public
BackgroundStyleApplicatorinstead.Changelog:
[Android][Breaking] - Set "enableBackgroundStyleApplicator" by default
Differential Revision: D60365677