Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[LOCAL][CI] Fetch Github tags in the publish-release job #46127

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

cipolleschi
Copy link
Contributor

@cipolleschi cipolleschi commented Aug 21, 2024

Summary:

React native 0.75.0, 0.75.1 and 0.75.2 has been published to NPM without the latest tag, despite the tag being on the commit.

When debugging why that's happened, I realized that we were not downloading the tags when checking out the repo.
Screenshot 2024-08-21 at 11 23 57

This change fixes that.

Changelog:

[Internal] - Publish React native as latest when the latest tag is specified on git

Test Plan:

Next release. We can't run a dry-run test without landing the change first.

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Aug 21, 2024
@react-native-bot
Copy link
Collaborator

Fails
🚫

📋 Verify Changelog Format - See Changelog format

Warnings
⚠️ 🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against 98b6877

@cipolleschi cipolleschi changed the base branch from main to 0.75-stable August 21, 2024 10:24
@cipolleschi cipolleschi marked this pull request as ready for review August 21, 2024 10:25
@cipolleschi cipolleschi changed the title [LOCAL][CI] Fetch in the publish-release job [LOCAL][CI] Fetch Github tags in the publish-release job Aug 21, 2024
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 20,743,780 -611,076
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 23,945,526 -604,465
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: fcd526d
Branch: main

@cipolleschi cipolleschi merged commit 4fb43c3 into 0.75-stable Sep 11, 2024
48 of 51 checks passed
@cipolleschi cipolleschi deleted the cipolleschi/fetch-tags-release branch September 11, 2024 09:15
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner Pick Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants