-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add jsBundleFile to DefaultReactNativeHost.kt #47188
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Oct 24, 2024
Error ReferenceError
Dangerfile
|
facebook-github-bot
added
the
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
label
Oct 24, 2024
cortinico
approved these changes
Oct 24, 2024
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@cortinico merged this pull request in d293fdd. |
This pull request was successfully merged by @sunnylqm in d293fdd When will my fix make it into a release? | How to file a pick request? |
blakef
pushed a commit
that referenced
this pull request
Oct 28, 2024
Summary: The JsBundleFilePath has been ignored when converting DefaultReactNativeHost to ReactHost Changelog: [Internal] [Changed] - Add jsBundleFile to DefaultReactNativeHost.kt Pull Request resolved: #47188 Reviewed By: javache Differential Revision: D64914149 Pulled By: cortinico fbshipit-source-id: d437ca81df5a170e0c5f01a22ccda83f43a09dd2
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Merged
This PR has been merged.
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JsBundleFilePath has been ignored when converting DefaultReactNativeHost to ReactHost