Rename SystraceSection to TraceSection #48383
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D67621914 |
|
This pull request was exported from Phabricator. Differential Revision: D67621914 |
rshest
added a commit
to rshest/react-native
that referenced
this pull request
Dec 24, 2024
Summary: Pull Request resolved: facebook#48383 ## Changelog: [Internal] - This changes the name of `SystraceSection` class to `TraceSection`, the purpose being to make it Systrace/FBSystrace agnostic (and that it can be mapped to e.g. Perfetto instead). It changes all the internal callsites to the RN code code, and also adds a shim include, `<cxxreact/SystraceSection.h`, for backward compatibility with the external callers for now (which will be addressed separately). Reviewed By: javache Differential Revision: D67621914
rshest
force-pushed
the
export-D67621914
branch
from
a9fe3f6 to
83d3d76
Compare
rshest
added a commit
to rshest/react-native
that referenced
this pull request
Dec 24, 2024
Summary: Pull Request resolved: facebook#48383 ## Changelog: [Internal] - This changes the name of `SystraceSection` class to `TraceSection`, the purpose being to make it Systrace/FBSystrace agnostic (and that it can be mapped to e.g. Perfetto instead). It changes all the internal callsites to the RN code code, and also adds a shim include, `<cxxreact/SystraceSection.h`, for backward compatibility with the external callers for now (which will be addressed separately). Reviewed By: javache Differential Revision: D67621914
rshest
force-pushed
the
export-D67621914
branch
from
83d3d76 to
dbcab35
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67621914 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D67621914 |
rshest
force-pushed
the
export-D67621914
branch
from
dbcab35 to
87dbb99
Compare
rshest
added a commit
to rshest/react-native
that referenced
this pull request
Dec 24, 2024
Summary: Pull Request resolved: facebook#48383 ## Changelog: [Internal] - This changes the name of `SystraceSection` class to `TraceSection`, the purpose being to make it Systrace/FBSystrace agnostic (and that it can be mapped to e.g. Perfetto instead). It changes all the internal callsites to the RN code code, and also adds a shim include, `<cxxreact/SystraceSection.h`, for backward compatibility with the external callers for now (which will be addressed separately). Reviewed By: javache Differential Revision: D67621914
rshest
added a commit
to rshest/react-native
that referenced
this pull request
Dec 24, 2024
Summary: Pull Request resolved: facebook#48383 ## Changelog: [Internal] - This changes the name of `SystraceSection` class to `TraceSection`, the purpose being to make it Systrace/FBSystrace agnostic (and that it can be mapped to e.g. Perfetto instead). It changes all the internal callsites to the RN code code, and also adds a shim include, `<cxxreact/SystraceSection.h`, for backward compatibility with the external callers for now (which will be addressed separately). Reviewed By: javache Differential Revision: D67621914
rshest
force-pushed
the
export-D67621914
branch
from
87dbb99 to
9900208
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67621914 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D67621914 |
rshest
added a commit
to rshest/react-native
that referenced
this pull request
Dec 24, 2024
Summary: Pull Request resolved: facebook#48383 ## Changelog: [Internal] - This changes the name of `SystraceSection` class to `TraceSection`, the purpose being to make it Systrace/FBSystrace agnostic (and that it can be mapped to e.g. Perfetto instead). It changes all the internal callsites to the RN code code, and also adds a shim include, `<cxxreact/SystraceSection.h`, for backward compatibility with the external callers for now (which will be addressed separately). Reviewed By: javache Differential Revision: D67621914
rshest
force-pushed
the
export-D67621914
branch
from
9900208 to
71ddb92
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67621914 |
rshest
force-pushed
the
export-D67621914
branch
from
71ddb92 to
fc40d9e
Compare
rshest
added a commit
to rshest/react-native
that referenced
this pull request
Dec 24, 2024
Summary: Pull Request resolved: facebook#48383 ## Changelog: [Internal] - This changes the name of `SystraceSection` class to `TraceSection`, the purpose being to make it Systrace/FBSystrace agnostic (and that it can be mapped to e.g. Perfetto instead). It changes all the internal callsites to the RN code code, and also adds a shim include, `<cxxreact/SystraceSection.h`, for backward compatibility with the external callers for now (which will be addressed separately). Reviewed By: javache Differential Revision: D67621914
Summary: Pull Request resolved: facebook#48383 ## Changelog: [Internal] - This changes the name of `SystraceSection` class to `TraceSection`, the purpose being to make it Systrace/FBSystrace agnostic (and that it can be mapped to e.g. Perfetto instead). It changes all the internal callsites to the RN code code, and also adds a shim include, `<cxxreact/SystraceSection.h`, for backward compatibility with the external callers for now (which will be addressed separately). Reviewed By: javache Differential Revision: D67621914
rshest
force-pushed
the
export-D67621914
branch
from
fc40d9e to
307334d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67621914 |
|
This pull request has been merged in fcf3c8c. |
|
This pull request was successfully merged by @rshest in fcf3c8c When will my fix make it into a release? | How to file a pick request? |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
[Internal] -
This changes the name of
SystraceSectionclass toTraceSection, the purpose being to make it Systrace/FBSystrace agnostic (and that it can be mapped to e.g. Perfetto instead).It changes all the internal callsites to the RN code code, and also adds a shim include,
<cxxreact/SystraceSection.h, for backward compatibility with the external callers for now (which will be addressed separately).Differential Revision: D67621914