Prepare for removal of types in ReactNativeTypes #49602
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D69996009 |
|
This pull request was exported from Phabricator. Differential Revision: D69996009 |
rubennorte
force-pushed
the
export-D69996009
branch
from
758f3c6 to
5521c68
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69996009 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Feb 24, 2025
Summary: Pull Request resolved: facebook#49602 Changelog: [internal] This just prepares for the removal of some types from `ReactNativeTypes`, and defines some types in `ReactNativePrivateInterface` that `ReactNativeTypes` expects to be defined after facebook/react#32446 Differential Revision: D69996009
rubennorte
force-pushed
the
export-D69996009
branch
from
5521c68 to
9645308
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69996009 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Feb 24, 2025
Summary: Pull Request resolved: facebook#49602 Changelog: [internal] This just prepares for the removal of some types from `ReactNativeTypes`, and defines some types in `ReactNativePrivateInterface` that `ReactNativeTypes` expects to be defined after facebook/react#32446 Differential Revision: D69996009
rubennorte
force-pushed
the
export-D69996009
branch
from
9645308 to
587ccd1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69996009 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Feb 24, 2025
Summary: Pull Request resolved: facebook#49602 Changelog: [internal] This just prepares for the removal of some types from `ReactNativeTypes`, and defines some types in `ReactNativePrivateInterface` that `ReactNativeTypes` expects to be defined after facebook/react#32446 Reviewed By: huntie Differential Revision: D69996009
rubennorte
force-pushed
the
export-D69996009
branch
from
587ccd1 to
0b339b4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69996009 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Feb 24, 2025
Summary: Pull Request resolved: facebook#49602 Changelog: [internal] This just prepares for the removal of some types from `ReactNativeTypes`, and defines some types in `ReactNativePrivateInterface` that `ReactNativeTypes` expects to be defined after facebook/react#32446 Reviewed By: huntie Differential Revision: D69996009
rubennorte
force-pushed
the
export-D69996009
branch
from
0b339b4 to
8219561
Compare
Summary: Pull Request resolved: facebook#49602 Changelog: [internal] This just prepares for the removal of some types from `ReactNativeTypes`, and defines some types in `ReactNativePrivateInterface` that `ReactNativeTypes` expects to be defined after facebook/react#32446 Reviewed By: huntie Differential Revision: D69996009
|
This pull request was exported from Phabricator. Differential Revision: D69996009 |
rubennorte
force-pushed
the
export-D69996009
branch
from
8219561 to
e5ae92a
Compare
|
This pull request has been merged in dbc0bf3. |
rubennorte
added a commit
to facebook/react
that referenced
this pull request
Feb 24, 2025
…ce (#32446) ## Summary > [!NOTE] > This only modifies types, so shouldn't have an impact at runtime. Some time ago we moved some type definitions from React to React Native in #26437. This continues making progress on that so values that are created by React Native and passed to the React renderer (in this case public instances) are actually defined in React Native and not in React. This will allow us to modify the definition of some of these types without having to make changes in the React repository (in the short term, we want to refactor PublicInstance from an object to an interface, and then modify that interface to add all the new DOM methods). ## How did you test this change? Manually synced `ReactNativeTypes` on top of facebook/react-native#49602 and verified Flow passes.
github-actions bot
pushed a commit
to facebook/react
that referenced
this pull request
Feb 24, 2025
…ce (#32446) ## Summary > [!NOTE] > This only modifies types, so shouldn't have an impact at runtime. Some time ago we moved some type definitions from React to React Native in #26437. This continues making progress on that so values that are created by React Native and passed to the React renderer (in this case public instances) are actually defined in React Native and not in React. This will allow us to modify the definition of some of these types without having to make changes in the React repository (in the short term, we want to refactor PublicInstance from an object to an interface, and then modify that interface to add all the new DOM methods). ## How did you test this change? Manually synced `ReactNativeTypes` on top of facebook/react-native#49602 and verified Flow passes. DiffTrain build for [9dd378f](9dd378f)
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Feb 24, 2025
…acebook#32446) Summary: ## Summary > [!NOTE] > This only modifies types, so shouldn't have an impact at runtime. Some time ago we moved some type definitions from React to React Native in facebook#26437. This continues making progress on that so values that are created by React Native and passed to the React renderer (in this case public instances) are actually defined in React Native and not in React. This will allow us to modify the definition of some of these types without having to make changes in the React repository (in the short term, we want to refactor PublicInstance from an object to an interface, and then modify that interface to add all the new DOM methods). ## How did you test this change? Manually synced `ReactNativeTypes` on top of facebook#49602 and verified Flow passes. DiffTrain build for [9dd378ff1222335ff133bab2d61001fcc84a1c56](facebook/react@9dd378f) Differential Revision: D70091830
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Feb 24, 2025
…terface (facebook#32446) Summary: ## Summary > [!NOTE] > This only modifies types, so shouldn't have an impact at runtime. Some time ago we moved some type definitions from React to React Native in facebook#26437. This continues making progress on that so values that are created by React Native and passed to the React renderer (in this case public instances) are actually defined in React Native and not in React. This will allow us to modify the definition of some of these types without having to make changes in the React repository (in the short term, we want to refactor PublicInstance from an object to an interface, and then modify that interface to add all the new DOM methods). ## How did you test this change? Manually synced `ReactNativeTypes` on top of facebook#49602 and verified Flow passes. DiffTrain build for [9dd378ff1222335ff133bab2d61001fcc84a1c56](facebook/react@9dd378f) Differential Revision: D70091830
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Feb 24, 2025
…acebook#32446) Summary: ## Summary > [!NOTE] > This only modifies types, so shouldn't have an impact at runtime. Some time ago we moved some type definitions from React to React Native in facebook#26437. This continues making progress on that so values that are created by React Native and passed to the React renderer (in this case public instances) are actually defined in React Native and not in React. This will allow us to modify the definition of some of these types without having to make changes in the React repository (in the short term, we want to refactor PublicInstance from an object to an interface, and then modify that interface to add all the new DOM methods). ## How did you test this change? Manually synced `ReactNativeTypes` on top of facebook#49602 and verified Flow passes. DiffTrain build for [9dd378ff1222335ff133bab2d61001fcc84a1c56](facebook/react@9dd378f) Differential Revision: D70091830
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 26, 2025
…32446) Summary: ## Summary > [!NOTE] > This only modifies types, so shouldn't have an impact at runtime. Some time ago we moved some type definitions from React to React Native in #26437. This continues making progress on that so values that are created by React Native and passed to the React renderer (in this case public instances) are actually defined in React Native and not in React. This will allow us to modify the definition of some of these types without having to make changes in the React repository (in the short term, we want to refactor PublicInstance from an object to an interface, and then modify that interface to add all the new DOM methods). ## How did you test this change? Manually synced `ReactNativeTypes` on top of #49602 and verified Flow passes. DiffTrain build for [9dd378ff1222335ff133bab2d61001fcc84a1c56](facebook/react@9dd378f) Reviewed By: poteto Differential Revision: D70091830 fbshipit-source-id: 2cc49d8ed89e8ee2531dbc4094ef9720fc3040ad
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
This just prepares for the removal of some types from
ReactNativeTypes, and defines some types inReactNativePrivateInterfacethatReactNativeTypesexpects to be defined after (PR).Differential Revision: D69996009