Fix: swiping in navigator too quickly causes the gesture to be lost #6249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @jmstout, @ericvicenti and @hedgerwang to be potential reviewers. |
facebook-github-bot
added
GH Review: review-needed
CLA Signed
felixakiragreen
force-pushed
the
bug-navigator-swiping-too-fast
branch
from
0fce616 to
a178be0
Compare
| @@ -804,8 +806,11 @@ var Navigator = React.createClass({ | |||
| -(SCREEN_HEIGHT - edgeHitWidth) : | |||
| -(SCREEN_WIDTH - edgeHitWidth); | |||
| } | |||
There was a problem hiding this comment.
eqeqeq: Expected '===' and instead saw '=='.
felixakiragreen
force-pushed
the
bug-navigator-swiping-too-fast
branch
from
a178be0 to
7a729da
Compare
|
@DUBERT updated the pull request. |
1 similar comment
|
@DUBERT updated the pull request. |
felixakiragreen
force-pushed
the
bug-navigator-swiping-too-fast
branch
from
3d74e6b to
c07c69e
Compare
felixakiragreen
changed the title
felixakiragreen
force-pushed
the
bug-navigator-swiping-too-fast
branch
from
c07c69e to
d638957
Compare
|
@DUBERT updated the pull request. |
|
Would @jmstout, @ericvicenti or @hedgerwang mind reviewing this? It's a pretty annoying and significant bug. |
|
@ericvicenti would you mind taking a look at this pull request? It's been a while since the last commit was reviewed. |
|
Sorry for the big delay for such a clear fix! |
|
@facebook-github-bot shipit |
facebook-github-bot
added
GH Review: accepted
and removed
GH Review: review-needed
labels
|
Thanks for importing. If you are an FB employee go to Phabricator to review. |
format code change == to ===
felixakiragreen
force-pushed
the
bug-navigator-swiping-too-fast
branch
from
d638957 to
56dd6f6
Compare
|
@DUBERT updated the pull request. |
ghost
closed this
in
zebulgar
pushed a commit
to nightingale/react-native
that referenced
this pull request
Jun 18, 2016
Summary:**Issue:** In the Navigator if a user attempts to navigate backwards (or forwards) through the route stack by swiping and they perform the gesture too quickly, the gesture is lost and nothing happens. **Cause:** In the `_matchGestureAction` function, the variable `moveStartedInRegion` is created and evaluates the gesture to determine if it was initiated in a valid region, (a.k.a. within the `edgeHitWidth`). The issue arises because `moveStartedInRegion` uses `currentLoc` (which is created from `gestureState.moveX`/`Y`) and when the gesture is performed using a flick of the finger, the first value of the `currentLoc` is outside of the `edgeHitWidth`. **Solution:** The solution is to track the coordinates of the initial grant (`gestureState.x0`/`y0`), and use that value instead of the `currentLoc` when evaluating `moveStartedInRegion`. The `currentLoc` is still needed however, for when the gestureState does not have a an initial x and y value, because the pan responder has not been granted. Closes facebook#6249 Differential Revision: D3168726 Pulled By: ericvicenti fb-gh-sync-id: f2ac462e59bdc38536b99cac6a4877c99fa4e869 fbshipit-source-id: f2ac462e59bdc38536b99cac6a4877c99fa4e869
This pull request was closed.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
In the Navigator if a user attempts to navigate backwards (or forwards) through the route stack by swiping and they perform the gesture too quickly, the gesture is lost and nothing happens.
Cause:
In the
_matchGestureActionfunction, the variablemoveStartedInRegionis created and evaluates the gesture to determine if it was initiated in a valid region, (a.k.a. within theedgeHitWidth). The issue arises becausemoveStartedInRegionusescurrentLoc(which is created fromgestureState.moveX/Y) and when the gesture is performed using a flick of the finger, the first value of thecurrentLocis outside of theedgeHitWidth.Solution:
The solution is to track the coordinates of the initial grant (
gestureState.x0/y0), and use that value instead of thecurrentLocwhen evaluatingmoveStartedInRegion. ThecurrentLocis still needed however, for when the gestureState does not have a an initial x and y value, because the pan responder has not been granted.