Skip to content

react-test-renderer: toTree() does not yet know how to handle nodes with tag=10 #12106

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
ambar opened this issue Jan 27, 2018 · 3 comments · Fixed by #12154
Closed

react-test-renderer: toTree() does not yet know how to handle nodes with tag=10 #12106

ambar opened this issue Jan 27, 2018 · 3 comments · Fixed by #12154
Labels
Component: Test Renderer Type: Bug

Comments

@ambar
Copy link

ambar commented Jan 27, 2018

Do you want to request a feature or report a bug?

bug.

What is the current behavior?

  renderer.create(
    <Fragment>
      <Fragment>foo</Fragment>
    </Fragment>
  )
  .toTree()

Invariant Violation: toTree() does not yet know how to handle nodes with tag=10

https://codesandbox.io/s/olky92m01y

What is the expected behavior?

returns a tree.

Which versions of React, and which browser / OS are affected by this issue? Did this work in previous versions of React?

16.2.0
@gaearon
Copy link
Collaborator

gaearon commented Jan 27, 2018

This does look like a bug (or rather missing functionality).
Would you like to send a PR?

@maciej-ka
Copy link
Contributor

I would give it a try.

maciej-ka added a commit to maciej-ka/react that referenced this issue Jan 27, 2018
@maciej-ka
Handle nested Fragments in toTree (facebook#12106)
2193456
maciej-ka added a commit to maciej-ka/react that referenced this issue Jan 27, 2018
@maciej-ka
Handle nested Fragments in toTree (facebook#12106)
7c1fdc3
@maciej-ka maciej-ka mentioned this issue Jan 27, 2018
Merged
@aweary
Copy link
Contributor

aweary commented Jan 27, 2018

Thanks @maciej-ka!

@aweary aweary closed this as completed Jan 27, 2018
aweary pushed a commit that referenced this issue Jan 27, 2018
@maciej-ka @aweary
Handle nested Fragments in toTree (#12106) (#12107)
ef8d6d9
@ambar ambar mentioned this issue Jan 28, 2018
Closed
@gaearon gaearon mentioned this issue Feb 5, 2018
Merged
NMinhNguyen referenced this issue in enzymejs/react-shallow-renderer Jan 29, 2020
@maciej-ka @aweary
Handle nested Fragments in toTree (#12106) (#12107)
4a38d6d
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
Component: Test Renderer Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix fragment and portal handling in toTree() gaearon/react
4 participants
@ambar @gaearon @maciej-ka @aweary