Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

IE 10 Member not found. #7320

Closed
igorushko opened this issue Jul 20, 2016 · 2 comments
Closed

IE 10 Member not found. #7320

igorushko opened this issue Jul 20, 2016 · 2 comments

Comments

@igorushko
Copy link

I catch Member not found exception on react 15.2.1 and ie10

It is on input onChange in SyntheticEvent on event.cancelBubble = true; line

stopPropagation: function () {
        var event = this.nativeEvent;
        if (!event) {
          return;
        }
        if (event.stopPropagation) {
          event.stopPropagation();
        } else {
          event.cancelBubble = true;
        }
        this.isPropagationStopped = emptyFunction.thatReturnsTrue;
      }
nhunzaker added a commit to nhunzaker/react that referenced this issue Jul 23, 2016
'change' custom events raise "Member not found" in <= IE10. To
circumvent this, the SyntheticEvent class now checks for "typeof
event.cancelBubble !== 'unknown'". This eliminates this exception and
maintains the expected bubbling functionality.

Addresses facebook#7320.
@nhunzaker
Copy link
Contributor

This isn't an issue on master, but I believe it's because of a change to controlled inputs here: 045f1a7. I could be wrong, but I think this is because it avoids creating a custom change event (But really, I don't know).

This occurs when dispatching custom events that don't bubble (I believe) in IE. There are a couple of work arounds, one is to perform a check like typeof event.cancelBubble !== 'unknown'. This is mentioned in the jQuery issue tracker:

https://bugs.jquery.com/ticket/10004

My intuition here says that this would some how hinder bubbling. But it does not! I tested this against IE9-11, Chrome, Firefox, and Safari.

I've got a PR here with the details:

#7343

nhunzaker added a commit to nhunzaker/react that referenced this issue Jul 23, 2016
'change' custom events raise "Member not found" in <= IE10. To
circumvent this, the SyntheticEvent class now checks for "typeof
event.cancelBubble !== 'unknown'". This eliminates this exception and
maintains the expected bubbling functionality.

Addresses facebook#7320.
nhunzaker added a commit to nhunzaker/react that referenced this issue Jul 25, 2016
'change' custom events raise "Member not found" in <= IE10. To
circumvent this, the SyntheticEvent class now checks for "typeof
event.cancelBubble !== 'unknown'". This eliminates this exception and
maintains the expected bubbling functionality.

Addresses facebook#7320.
nhunzaker added a commit to nhunzaker/react that referenced this issue Jul 25, 2016
'change' custom events raise "Member not found" in <= IE10. To
circumvent this, the SyntheticEvent class now checks for "typeof
event.cancelBubble !== 'unknown'". This eliminates this exception and
maintains the expected bubbling functionality.

Addresses facebook#7320.
nhunzaker added a commit to nhunzaker/react that referenced this issue Jul 25, 2016
'change' custom events raise "Member not found" in <= IE10. To
circumvent this, the SyntheticEvent class now checks for "typeof
event.cancelBubble !== 'unknown'". This eliminates this exception and
maintains the expected bubbling functionality.

Addresses facebook#7320.
sophiebits pushed a commit that referenced this issue Jul 31, 2016
'change' custom events raise "Member not found" in <= IE10. To
circumvent this, the SyntheticEvent class now checks for "typeof
event.cancelBubble !== 'unknown'". This eliminates this exception and
maintains the expected bubbling functionality.

Addresses #7320.
gmp pushed a commit to gmp/react that referenced this issue Aug 3, 2016
Explanation and similar change as facebook#7343

Addresses facebook#7320
gmp pushed a commit to gmp/react that referenced this issue Aug 3, 2016
Explanation, discussion, and similar change as facebook#7343

Addresses facebook#7320
gmp added a commit to gmp/react that referenced this issue Aug 12, 2016
Explanation, discussion, and similar change as facebook#7343

Addresses facebook#7320
gmp added a commit to gmp/react that referenced this issue Aug 12, 2016
Explanation, discussion, and similar change as facebook#7343

Addresses facebook#7320
zpao pushed a commit that referenced this issue Aug 12, 2016
'change' custom events raise "Member not found" in <= IE10. To
circumvent this, the SyntheticEvent class now checks for "typeof
event.cancelBubble !== 'unknown'". This eliminates this exception and
maintains the expected bubbling functionality.

Addresses #7320.
(cherry picked from commit 2823dfc)
aweary pushed a commit that referenced this issue Aug 19, 2016
Explanation, discussion, and similar change as #7343

Addresses #7320
zpao pushed a commit that referenced this issue Sep 15, 2016
Explanation, discussion, and similar change as #7343

Addresses #7320
(cherry picked from commit a874196)
@nhunzaker
Copy link
Contributor

Did we fully address this between #7411 and #7343 ? I think this can be closed.

@gaearon gaearon closed this as completed Oct 4, 2017
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

4 participants