Skip to content

Support of "as" on Link for PreLoad #7543

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
SunnyGurnani opened this issue Aug 22, 2016 · 4 comments
Closed

Support of "as" on Link for PreLoad #7543

SunnyGurnani opened this issue Aug 22, 2016 · 4 comments
Labels
Component: DOM Difficulty: starter

Comments

@SunnyGurnani
Copy link

SunnyGurnani commented Aug 22, 2016 •
edited by zpao
Loading

rel="preload" is the new functionality in latest browsers to preload the content. However Reactjs currently strips "as" on <Link>

Here is the warning we get : Unknown prop as on <link> tag. Remove this prop from the element. For details,
@zpao
Copy link
Member

zpao commented Aug 23, 2016

Would you be interested in adding it?

@soupaJ
Copy link

soupaJ commented Aug 23, 2016

If @SunnyGurnani does not want to add it, may I give it a try?

kevinslin pushed a commit to kevinslin/react that referenced this issue Aug 26, 2016
Add 'as' keyword (facebook#7543)
5750073
@kevinslin
Copy link
Contributor

Ran into this issue as well so made the fix (apologies @soupaJ). This is my first time contributing to react so please let me know if there's something missing. Signed the CLA and followed instructions outlined in the CONTRIBUTING section

aweary pushed a commit that referenced this issue Aug 30, 2016
@kevinslin @aweary
Add 'as' keyword (#7543) (#7582)
c85f463 
* Add 'as' keyword (#7543)

* fix commenting to adhere to styling

* fix grammar in comment
@aweary
Copy link
Contributor

aweary commented Aug 30, 2016

Closed in #7582

@aweary aweary closed this as completed Aug 30, 2016
zpao pushed a commit that referenced this issue Sep 15, 2016
@kevinslin @zpao
Add 'as' keyword (#7543) (#7582)
3e47b30 
* Add 'as' keyword (#7543)

* fix commenting to adhere to styling

* fix grammar in comment

(cherry picked from commit c85f463)
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
Component: DOM Difficulty: starter
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@zpao @kevinslin @SunnyGurnani @soupaJ @aweary