-
Notifications
You must be signed in to change notification settings - Fork 48.5k
Use boolean assertion for documentMode check #10032
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
This change was already made in master as well: #7594 It just wasn't included in the backport. |
Why does #7594 change two lines but this PR changes one? |
Mind creating an issue linking to everything that's still necessary for 15.6.x? Another one I'm thinking about is CurrentOwner bugfix. |
Need to run |
@gaearon is the
I can commit these changes (in a separate PR probably) if you'd like @gaearon |
Hmm. It used to work but maybe we're not yet using Yarn there so we need to cherry-pick #10038? |
I think we might have gotten a false positive on the commit where we first ran prettier. I just re-ran the build without cache and it looks like the prettier step failed: https://circleci.com/gh/facebook/react/4254 It's hard to tell what version of prettier ran - possibly 1.4 - but do you think we just need to run prettier 1.2.2.0 again on 15.6-dev as @aweary suggested? |
I'm cool either way, let's just get the branch to be green. |
2e092ea
to
2c70e8e
Compare
cc @gaearon @nhunzaker CI is now green 🎉 |
Resolves #10030
Reverts a small change made in #8575. This should be safe, as we still use this assertion for the change event bubbling check.
cc @flarnie @gaearon this will require another 15.6.x release (not sure if one was planned)