Add node-stream.js to react-dom's package.json files entry #10044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the file to be uploaded to npm.
|
@gaearon when/will this be available in a future release? It doesn't seem to be in https://unpkg.com/react-dom@16.0.0-beta.5/package.json (It was in (The docs reference this API, which appears to have been recently updated) Thanks so much! |
|
@magicmark In the latest release, they're just available directly on |
This was referenced Sep 28, 2017
This was referenced Oct 28, 2017
This was referenced Dec 1, 2017
This was referenced Feb 2, 2018
This was referenced Mar 21, 2018
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #10024, I added
node-stream.jstoreact-dom's distribution, but I didn't realize thatreact-dom's package.json specifies which files are to be uploaded to the npm registry. As a result, if we tried to publishreact-domright now out of master,node-stream.jswould not be a part of the package.This PR fixes that. Sorry!