Skip to content

Add note about mistaken named / default export #11505

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Nov 9, 2017
Merged

Add note about mistaken named / default export #11505

merged 1 commit into from
Nov 9, 2017

Conversation

selbekk
Copy link
Contributor

@selbekk selbekk commented Nov 9, 2017

This commit adds a note about the possibility of erroneously
mistaking named and default exports to an existing error message.

Ref this issue.

Copy link
Collaborator

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's change "mistaken" to "mixed up". Seems better grammar-wise.

This commit adds a note about the possibility of erroneously
mistaking named and default exports to an existing error message.
@selbekk
Copy link
Contributor Author

selbekk commented Nov 9, 2017

I agree 👍

@gaearon gaearon merged commit 5bfb878 into facebook:master Nov 9, 2017
@gaearon
Copy link
Collaborator

gaearon commented Nov 9, 2017

Very nice. Thank you.

@selbekk
Copy link
Contributor Author

selbekk commented Nov 9, 2017

No problem whatsoever :-)

Ethan-Arrowood pushed a commit to Ethan-Arrowood/react that referenced this pull request Dec 8, 2017
This commit adds a note about the possibility of erroneously
mistaking named and default exports to an existing error message.
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants