Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

tests: add regression test for reading ReactCurrentOwner stateNode #12412

Merged
merged 2 commits into from
Apr 16, 2018
Merged

tests: add regression test for reading ReactCurrentOwner stateNode #12412

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39475ee
tests: add regression test for reading ReactCurrentOwner stateNode
raunofreiberg Mar 21, 2018
a8d5826
tests: replace expect with just rendering the component
raunofreiberg Mar 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions packages/react-dom/src/__tests__/ReactDOM-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,6 +377,26 @@ describe('ReactDOM', () => {
}
});

it('should not crash calling findDOMNode inside a functional component', () => {
const container = document.createElement('div');

class Component extends React.Component {
render() {
return <div />;
}
}

const instance = ReactTestUtils.renderIntoDocument(<Component />);
const App = () => {
ReactDOM.findDOMNode(instance);
return <div />;
};

if (__DEV__) {
ReactDOM.render(<App />, container);
}
});

it('throws in DEV if jsdom is destroyed by the time setState() is called', () => {
class App extends React.Component {
state = {x: 1};
Expand Down