Upgrade to Jest 23 #12894
Merged
Upgrade to Jest 23 #12894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
force-pushed
the
upgrade-jest
branch
2 times, most recently
from
3a71609 to
67991b4
Compare
thymikee
reviewed
May 28, 2018
package.json
Outdated
| @@ -69,8 +69,8 @@ | |||
| "gzip-js": "~0.3.2", | |||
| "gzip-size": "^3.0.0", | |||
| "jasmine-check": "^1.0.0-rc.0", | |||
| "jest": "^22.4.4", | |||
| "jest-diff": "^22.4.3", | |||
| "jest": "^23.0.0-charlie.4", | |||
|
Sorry we missed this, do you mind fixing up merge conflicts? |
|
@gaearon rebased and upgraded to 23.0.1 |
thymikee
approved these changes
May 28, 2018
|
|
|
Thanks! |
NMinhNguyen
referenced
this pull request
in enzymejs/react-shallow-renderer
Jan 29, 2020
* Upgrade to Jest 23 beta * prefer `.toHaveBeenCalledTimes` * 23 stable
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋
I upgraded in order to check for regressions. And as I made the migration, I thought I might as well push it and make a PR.
This also includes some refatoring moving from jasmine based spies to the Jest ones.
I started migrating your
spyOnDevstuff, but that was... a lot. So I pulled out. Sorry!