Use Entry in yarn build ... Instead of Label
#14148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that `yarn build core dom` includes DOM. It also ensures that spaces like `yarn build "core, dom"` doesn't build EVERYTHING.
Instead we just use the name from entry using fuzzy search. There is one special case. If you put in `/index` or `/index.js`. That allows to build things like `react/index` to only build isomorphic where as `react` would build everything. Or `react-dom/index` to exclude the server renderers.
sebmarkbage
requested review from
sophiebits,
bvaughn,
gaearon,
trueadm and
acdlite
Details of bundled changes.Comparing: 3ff2c7c...9e790ae scheduler
Generated by 🚫 dangerJS |
That way things like `yarn build react/` works too.
sebmarkbage
force-pushed
the
rmbuildlabel
branch
from
4e7e715 to
9e790ae
Compare
sophiebits
approved these changes
Nov 8, 2018
There was a problem hiding this comment.
Seems like ideally react would match only react but react-dom/server would match react-dom/server.node and react-dom/server.browser. What if foo means we match the name "foo" exactly as well as names starting with "foo." and "foo/"?
Can we also have it error and spit out all the bundle names if you don't pass valid input?
|
it's useful to do partial matches to some degree still. E.g. |
jetoneza
pushed a commit
to jetoneza/react
that referenced
this pull request
Jan 23, 2019
* Parse build script type and package names This ensures that `yarn build core dom` includes DOM. It also ensures that spaces like `yarn build "core, dom"` doesn't build EVERYTHING. * Get rid of label in bundles config Instead we just use the name from entry using fuzzy search. There is one special case. If you put in `/index` or `/index.js`. That allows to build things like `react/index` to only build isomorphic where as `react` would build everything. Or `react-dom/index` to exclude the server renderers. * Instead of matching `/index.js` just append it to the search string That way things like `yarn build react/` works too.
n8schloss
pushed a commit
to n8schloss/react
that referenced
this pull request
Jan 31, 2019
* Parse build script type and package names This ensures that `yarn build core dom` includes DOM. It also ensures that spaces like `yarn build "core, dom"` doesn't build EVERYTHING. * Get rid of label in bundles config Instead we just use the name from entry using fuzzy search. There is one special case. If you put in `/index` or `/index.js`. That allows to build things like `react/index` to only build isomorphic where as `react` would build everything. Or `react-dom/index` to exclude the server renderers. * Instead of matching `/index.js` just append it to the search string That way things like `yarn build react/` works too.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yarn build core,dom->yarn build react/index react-domor
yarn build core,dom-client->yarn build react/,dom/indexI've been frustrated that I can never guess what arguments
yarn buildexpects so always end up building everything.First, I improved the argument parsing a bit so that you don't have to separate the bundle names by commas. But commas still work. This ensures that
yarn build core domincludes DOM.It also ensures that spaces like
yarn build core, domdoesn't build EVERYTHING by becoming an empty entry which matches everything.I also got rid of label in bundles config. These follow a fairly arbitrary naming convention so I can never guess.
Instead I just use the name from npm entry name using fuzzy search.
There are some cases where this is weird. E.g.
yarn build reactbuilds everything since everything is called something withreactin it.There is one special case. The entry gets appended with
/index.jsat the end.That allows to build things like
yarn build react/to only build isomorphic. Oryarn build react-dom/indexto exclude the server renderers where asyarn build react-domincludes server renderers.