RFC: warn when returning different hooks on subsequent renders #14585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 14, 2019 04:08
like it says. adds a field to Hook to track effect 'type', and compares when cloning subsequently.
acdlite
reviewed
Jan 14, 2019
|
Maybe we could use react-debug-tools to print a warning that shows the expected the hook structure versus the actual one cc @bvaughn |
|
ReactDOM: size: 0.0%, gzip: 0.0% Details of bundled changes.Comparing: 3fbebb2...3ad6523 react-dom
react-art
react-native-renderer
react-test-renderer
react-reconciler
Generated by 🚫 dangerJS |
threepointone
commented
Jan 14, 2019
|
I’m thinking the message should emphasize the name of the top most hook that doesn’t match. Otherwise it’s not very helpful for custom hooks. |
threepointone
commented
Jan 14, 2019
packages/react-reconciler/src/__tests__/ReactHooks-test.internal.js
Outdated
Show resolved
Hide resolved
threepointone
changed the title
|
I have an odd bug in my test, where even though I'm matching the warning message exactly, |
added 4 commits
January 14, 2019 05:20
- numbered enum for hook types - s/hookType/_debugType - better dce
|
thanks for reviewing my PR on a sunday y'all :) |
added 2 commits
January 14, 2019 06:04
threepointone
commented
Jan 14, 2019
|
a couple that are missing
EDIT: done |
need to verify dce still works
bvaughn
reviewed
Jan 14, 2019
bvaughn
reviewed
Jan 14, 2019
aweary
reviewed
Jan 15, 2019
|
Looks like there's some overlap here with #14594 for tracking the hook name/type in DEV |
|
@aweary hrmm yeah you're right. I'll refactor. thanks for the catch! |
zhigang1992
reviewed
Jan 17, 2019
This was referenced Aug 31, 2019
This was referenced Sep 20, 2019
Open
[Snyk] Upgrade react-dom from 16.5.2 to 16.9.0
maxiplux/spring-security-react-ant-design-polls-app#3
Open
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
^ like it says. adds a field to
Hookto track hook 'type', and compares when cloning on further renders.started this PR/mvp to discuss how you folks would like this implemented?
I have run the tests (and added one!)