Skip to content

fix(auto-version-update): update root package version while publishing #15005

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Mar 4, 2019
Merged

fix(auto-version-update): update root package version while publishing #15005

merged 2 commits into from
Mar 4, 2019

Conversation

nutboltu
Copy link
Contributor

@nutboltu nutboltu commented Mar 3, 2019

Fixes #14985

Root Cause: #14201

In scripts/release/publish-commands scripts we only updated the packages versions and the version in ReactVersion.js. But not the root package version.

Possible Solutions

  • Updating the root package version number as per react version.
  • Remove version from root package json.

@aweary aweary requested a review from bvaughn March 4, 2019 05:10
@bvaughn
Copy link
Contributor

bvaughn commented Mar 4, 2019

I think we should just remove the version field entirely, since it's only in-sync with a few of the packages to begin with. Want to update the PR to do that?

@nutboltu
Copy link
Contributor Author

nutboltu commented Mar 4, 2019

@bvaughn I am going to remove version from the package.json

@bvaughn bvaughn merged commit ff596e3 into facebook:master Mar 4, 2019
@bvaughn
Copy link
Contributor

bvaughn commented Mar 4, 2019

Thanks~

@nutboltu nutboltu deleted the update-root-package-version branch March 4, 2019 21:05
@NE-SmallTown
Copy link
Contributor

NE-SmallTown commented Mar 5, 2019

I don't think we should remove this, because sometimes I want to check the react version on github(not on npm), so if I can't find the version field, it would be confusing

So, IMY, even it's unused, we still need sync the version in the root package.json

@bvaughn
Copy link
Contributor

bvaughn commented Mar 5, 2019

sometimes I want to check the react version on github(not on npm)

To be honest, that's not really a use case I think we are too worried about supporting, but you can check it here instead:
https://github.com/facebook/react/blob/master/packages/react/package.json#L7

@gaearon
Copy link
Collaborator

gaearon commented Mar 5, 2019

You can find the version here: https://reactjs.org

Top right corner

@nutboltu
Copy link
Contributor Author

nutboltu commented Mar 5, 2019

It's easy to find the version in CHANGELOG.md. Also you can see it in the README
react_version

@NE-SmallTown
Copy link
Contributor

Yea, I could find it at many places, changelog, release, package/react/package.json, reactjs.org, even in twitter. But from my perspective, it's a very common case that a open source js project describe it's version in the root package.json, right? I know there are some monorepos like react/babel remove the version, but add it is not a complicate cost, but will give someone a better experience.

But maybe I worry too much :)

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants