-
Notifications
You must be signed in to change notification settings - Fork 48.3k
fix(auto-version-update): update root package version while publishing #15005
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
I think we should just remove the |
@bvaughn I am going to remove version from the package.json |
Thanks~ |
I don't think we should remove this, because sometimes I want to check the react version on github(not on npm), so if I can't find the version field, it would be confusing So, IMY, even it's unused, we still need sync the version in the root package.json |
To be honest, that's not really a use case I think we are too worried about supporting, but you can check it here instead: |
You can find the version here: https://reactjs.org Top right corner |
It's easy to find the version in CHANGELOG.md. Also you can see it in the README |
Yea, I could find it at many places, changelog, release, package/react/package.json, reactjs.org, even in twitter. But from my perspective, it's a very common case that a open source js project describe it's version in the root package.json, right? I know there are some monorepos like react/babel remove the version, but add it is not a complicate cost, but will give someone a better experience. But maybe I worry too much :) |
Fixes #14985
Root Cause: #14201
In
scripts/release/publish-commands
scripts we only updated the packages versions and the version inReactVersion.js
. But not the root package version.Possible Solutions