Skip to content

Feature flag to revert #15650 #15659

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2019
Merged

Feature flag to revert #15650 #15659

merged 1 commit into from
May 15, 2019

Conversation

acdlite
Copy link
Collaborator

@acdlite acdlite commented May 15, 2019

PR #15650 is a bugfix but it's technically a semantic change that could cause regressions. I don't think it will be an issue, since the previous behavior was both broken and incoherent, but out of an abundance of caution, let's wrap it in a flag so we can easily revert it if necessary.

@acdlite
Feature flag to revert facebook#15650
e1ce30d 
PR facebook#15650 is a bugfix but it's technically a semantic change that could
cause regressions. I don't think it will be an issue, since the
previous behavior was both broken and incoherent, but out of an
abundance of caution, let's wrap it in a flag so we can easily revert
it if necessary.
@acdlite acdlite requested a review from threepointone May 15, 2019 19:54
@sizebot
Copy link

sizebot commented May 15, 2019 •
edited
Loading

ReactDOM: size: 🔺+0.1%, gzip: 🔺+0.1%

Details of bundled changes.

Comparing: 668fbd6...e1ce30d

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.development.js +0.1% +0.1% 830.39 KB 831.18 KB 189.55 KB 189.71 KB UMD_DEV
react-dom.production.min.js 🔺+0.1% 🔺+0.1% 104.02 KB 104.09 KB 33.76 KB 33.79 KB UMD_PROD
react-dom.profiling.min.js +0.1% +0.1% 107.18 KB 107.25 KB 34.73 KB 34.78 KB UMD_PROFILING
react-dom.development.js +0.1% +0.1% 824.8 KB 825.59 KB 188.01 KB 188.17 KB NODE_DEV
react-dom.production.min.js 🔺+0.1% 🔺+0.1% 104.02 KB 104.09 KB 33.21 KB 33.26 KB NODE_PROD
react-dom.profiling.min.js +0.1% +0.1% 107.36 KB 107.44 KB 34.12 KB 34.16 KB NODE_PROFILING
ReactDOM-dev.js +0.1% +0.1% 849.44 KB 850.21 KB 189.6 KB 189.72 KB FB_WWW_DEV
ReactDOM-prod.js 🔺+0.3% 🔺+0.4% 348.37 KB 349.37 KB 64.54 KB 64.77 KB FB_WWW_PROD
ReactDOM-profiling.js +0.3% +0.4% 353.5 KB 354.57 KB 65.53 KB 65.77 KB FB_WWW_PROFILING
react-dom-unstable-fire.development.js +0.1% +0.1% 830.74 KB 831.53 KB 189.71 KB 189.86 KB UMD_DEV
react-dom-unstable-fire.production.min.js 🔺+0.1% 🔺+0.1% 104.04 KB 104.11 KB 33.77 KB 33.8 KB UMD_PROD
react-dom-unstable-fire.profiling.min.js +0.1% +0.1% 107.19 KB 107.26 KB 34.74 KB 34.79 KB UMD_PROFILING
react-dom-unstable-fire.development.js +0.1% +0.1% 825.14 KB 825.93 KB 188.16 KB 188.31 KB NODE_DEV
react-dom-unstable-fire.production.min.js 🔺+0.1% 🔺+0.1% 104.03 KB 104.1 KB 33.22 KB 33.27 KB NODE_PROD
react-dom-unstable-fire.profiling.min.js +0.1% +0.1% 107.38 KB 107.45 KB 34.13 KB 34.17 KB NODE_PROFILING
ReactFire-dev.js +0.1% +0.1% 848.65 KB 849.42 KB 189.52 KB 189.64 KB FB_WWW_DEV
ReactFire-prod.js 🔺+0.3% 🔺+0.4% 336.34 KB 337.34 KB 62.06 KB 62.29 KB FB_WWW_PROD
ReactFire-profiling.js +0.3% +0.4% 341.45 KB 342.52 KB 63.02 KB 63.25 KB FB_WWW_PROFILING
react-dom-test-utils.development.js +0.1% +0.1% 54.38 KB 54.42 KB 15.04 KB 15.06 KB UMD_DEV
react-dom-test-utils.production.min.js 0.0% -0.1% 10.56 KB 10.56 KB 3.9 KB 3.89 KB UMD_PROD
react-dom-test-utils.development.js +0.1% +0.1% 54.1 KB 54.14 KB 14.97 KB 14.99 KB NODE_DEV
react-dom-test-utils.production.min.js 0.0% -0.1% 10.35 KB 10.35 KB 3.82 KB 3.82 KB NODE_PROD
ReactTestUtils-dev.js +0.1% +0.1% 51.59 KB 51.66 KB 13.9 KB 13.91 KB FB_WWW_DEV
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 60.76 KB 60.76 KB 15.85 KB 15.84 KB UMD_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.1% 10.69 KB 10.69 KB 3.67 KB 3.66 KB UMD_PROD
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 60.43 KB 60.43 KB 15.72 KB 15.72 KB NODE_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.1% 10.43 KB 10.43 KB 3.57 KB 3.56 KB NODE_PROD
react-dom-server.browser.development.js 0.0% +0.1% 136.83 KB 136.88 KB 36.04 KB 36.06 KB UMD_DEV
react-dom-server.browser.production.min.js 0.0% -0.0% 19.11 KB 19.11 KB 7.21 KB 7.21 KB UMD_PROD
react-dom-server.browser.development.js 0.0% +0.1% 132.97 KB 133.01 KB 35.11 KB 35.13 KB NODE_DEV
react-dom-server.browser.production.min.js 0.0% -0.0% 19.03 KB 19.03 KB 7.2 KB 7.2 KB NODE_PROD
ReactDOMServer-dev.js +0.1% 0.0% 135.32 KB 135.39 KB 34.76 KB 34.78 KB FB_WWW_DEV
ReactDOMServer-prod.js 0.0% -0.0% 47.85 KB 47.85 KB 11.01 KB 11.01 KB FB_WWW_PROD
react-dom-server.node.development.js 0.0% +0.1% 134.91 KB 134.96 KB 35.66 KB 35.68 KB NODE_DEV
react-dom-server.node.production.min.js 0.0% -0.0% 19.9 KB 19.9 KB 7.51 KB 7.51 KB NODE_PROD
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 3.81 KB 3.81 KB 1.54 KB 1.53 KB UMD_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.3% 1.21 KB 1.21 KB 706 B 704 B UMD_PROD
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 3.64 KB 3.64 KB 1.49 KB 1.49 KB NODE_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.3% 1.05 KB 1.05 KB 637 B 635 B NODE_PROD
react-dom-unstable-fizz.node.development.js 0.0% -0.1% 3.88 KB 3.88 KB 1.51 KB 1.51 KB NODE_DEV
react-dom-unstable-fizz.node.production.min.js 0.0% -0.3% 1.1 KB 1.1 KB 667 B 665 B NODE_PROD

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-art.development.js +0.1% +0.1% 564.83 KB 565.53 KB 123.91 KB 124.06 KB UMD_DEV
react-art.production.min.js 🔺+0.1% 🔺+0.1% 95.83 KB 95.9 KB 29.43 KB 29.47 KB UMD_PROD
react-art.development.js +0.1% +0.1% 495.79 KB 496.49 KB 106.49 KB 106.64 KB NODE_DEV
react-art.production.min.js 🔺+0.1% 🔺+0.3% 60.81 KB 60.88 KB 18.69 KB 18.75 KB NODE_PROD
ReactART-dev.js +0.1% +0.1% 505.25 KB 505.93 KB 105.64 KB 105.76 KB FB_WWW_DEV
ReactART-prod.js 🔺+0.5% 🔺+0.7% 196.11 KB 197.14 KB 33.29 KB 33.53 KB FB_WWW_PROD

react-native-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactNativeRenderer-dev.js +0.1% +0.1% 637.49 KB 638.23 KB 135.97 KB 136.1 KB RN_FB_DEV
ReactNativeRenderer-prod.js 🔺+0.3% 🔺+0.4% 244.38 KB 245.09 KB 42.4 KB 42.55 KB RN_FB_PROD
ReactNativeRenderer-profiling.js +0.3% +0.3% 252.41 KB 253.05 KB 44.06 KB 44.2 KB RN_FB_PROFILING
ReactNativeRenderer-dev.js +0.1% +0.1% 637.4 KB 638.15 KB 135.94 KB 136.07 KB RN_OSS_DEV
ReactNativeRenderer-prod.js 🔺+0.3% 🔺+0.4% 244.39 KB 245.1 KB 42.4 KB 42.55 KB RN_OSS_PROD
ReactNativeRenderer-profiling.js +0.3% +0.3% 252.43 KB 253.07 KB 44.06 KB 44.2 KB RN_OSS_PROFILING
ReactFabric-dev.js +0.1% +0.1% 626.24 KB 626.99 KB 133.22 KB 133.34 KB RN_FB_DEV
ReactFabric-prod.js 🔺+0.3% 🔺+0.3% 237.55 KB 238.25 KB 41.1 KB 41.23 KB RN_FB_PROD
ReactFabric-profiling.js +0.3% +0.4% 245.58 KB 246.22 KB 42.77 KB 42.93 KB RN_FB_PROFILING
ReactFabric-dev.js +0.1% +0.1% 626.15 KB 626.89 KB 133.18 KB 133.31 KB RN_OSS_DEV
ReactFabric-prod.js 🔺+0.3% 🔺+0.3% 237.55 KB 238.26 KB 41.09 KB 41.23 KB RN_OSS_PROD
ReactFabric-profiling.js +0.3% +0.4% 245.59 KB 246.23 KB 42.76 KB 42.93 KB RN_OSS_PROFILING

react-test-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-test-renderer.development.js +0.1% +0.1% 509.31 KB 509.97 KB 109.22 KB 109.33 KB UMD_DEV
react-test-renderer.production.min.js 🔺+0.1% 🔺+0.3% 62.05 KB 62.12 KB 19.03 KB 19.09 KB UMD_PROD
react-test-renderer.development.js +0.1% +0.1% 504.85 KB 505.51 KB 108.12 KB 108.23 KB NODE_DEV
react-test-renderer.production.min.js 🔺+0.1% 🔺+0.3% 61.73 KB 61.81 KB 18.9 KB 18.95 KB NODE_PROD
ReactTestRenderer-dev.js +0.1% +0.1% 515.98 KB 516.63 KB 107.91 KB 108.02 KB FB_WWW_DEV
react-test-renderer-shallow.development.js +0.1% +0.2% 41.57 KB 41.62 KB 10.7 KB 10.72 KB UMD_DEV
react-test-renderer-shallow.production.min.js 0.0% -0.1% 11.51 KB 11.51 KB 3.53 KB 3.53 KB UMD_PROD
react-test-renderer-shallow.development.js +0.1% +0.2% 35.71 KB 35.75 KB 9.33 KB 9.35 KB NODE_DEV
react-test-renderer-shallow.production.min.js 0.0% -0.1% 11.66 KB 11.66 KB 3.65 KB 3.65 KB NODE_PROD
ReactShallowRenderer-dev.js +0.2% +0.2% 34.67 KB 34.74 KB 8.7 KB 8.72 KB FB_WWW_DEV

react-reconciler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-reconciler.development.js +0.2% +0.2% 493.49 KB 494.28 KB 104.95 KB 105.12 KB NODE_DEV
react-reconciler.production.min.js 🔺+0.1% 🔺+0.2% 61.76 KB 61.84 KB 18.49 KB 18.53 KB NODE_PROD
react-reconciler-persistent.development.js +0.2% +0.1% 491.39 KB 492.14 KB 104.09 KB 104.23 KB NODE_DEV
react-reconciler-persistent.production.min.js 🔺+0.1% 🔺+0.2% 61.77 KB 61.85 KB 18.5 KB 18.54 KB NODE_PROD
react-reconciler-reflection.development.js +0.2% +0.3% 18.78 KB 18.83 KB 5.96 KB 5.98 KB NODE_DEV
react-reconciler-reflection.production.min.js 0.0% -0.1% 2.43 KB 2.43 KB 1.09 KB 1.09 KB NODE_PROD

Generated by 🚫 dangerJS

@acdlite acdlite force-pushed the feature-flag-to-revert-15650 branch 2 times, most recently from d0e98c5 to e1ce30d Compare May 15, 2019 20:16
@acdlite acdlite merged commit d34b457 into facebook:master May 15, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@threepointone threepointone threepointone approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@acdlite @sizebot @threepointone @facebook-github-bot