Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add package.json as one of entry point #22954

Merged
merged 1 commit into from Jan 7, 2022
Merged

Add package.json as one of entry point #22954

merged 1 commit into from Jan 7, 2022

Conversation

Jack-Works
Copy link
Contributor

Summary

Remove entry point build-info.json (close #22947)

Add entry point package.json (close storybookjs/storybook#16623)

I added package.json because it makes the storybook a fatal error in Node 17 because it tried to import this file.

How did you test this change?

@sizebot
Copy link

sizebot commented Dec 14, 2021

Comparing: 5757919...6f73b8c

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 129.54 kB 129.54 kB = 41.52 kB 41.51 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 134.68 kB 134.68 kB = 43.02 kB 43.02 kB
facebook-www/ReactDOM-prod.classic.js = 427.78 kB 427.78 kB = 78.55 kB 78.55 kB
facebook-www/ReactDOM-prod.modern.js = 417.47 kB 417.47 kB = 77.07 kB 77.07 kB
facebook-www/ReactDOMForked-prod.classic.js = 427.78 kB 427.78 kB = 78.55 kB 78.55 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 6f73b8c

@acdlite
Copy link
Collaborator

acdlite commented Jan 7, 2022

Looks good to me. Thank you! We'll release as part of the next RC (rc.1)

@acdlite acdlite merged commit fe905f1 into facebook:main Jan 7, 2022
facebook-github-bot pushed a commit to facebook/react-native that referenced this pull request Jan 10, 2022
Summary:
This sync includes the following changes:
- **[fe905f152](facebook/react@fe905f152 )**: Update package.json ([#22954](facebook/react#22954)) //<Jack Works>//
- **[3dc41d8a2](facebook/react@3dc41d8a2 )**: fix: parseExportNamesInto specifiers typo ([#22537](facebook/react#22537)) //<btea>//
- **[bd0a5dd68](facebook/react@bd0a5dd68 )**: #22988 - Fix Bug: license header in React 18 bundles contains vundefined ([#23004](facebook/react#23004)) //<Vitalie>//
- **[ceee524a8](facebook/react@ceee524a8 )**: Remove unnecessary clearContainer call ([#22979](facebook/react#22979)) //<Sebastian Markbåge>//
- **[cd1a3e9b5](facebook/react@cd1a3e9b5 )**: Build both a partial renderer and fizz renderer of the legacy API for FB ([#22933](facebook/react#22933)) //<Sebastian Markbåge>//

Changelog:
[General][Changed] - React Native sync for revisions a049aa0...fe905f1

jest_e2e[run_all_tests]

Reviewed By: rickhanlonii

Differential Revision: D33512179

fbshipit-source-id: c2df06c8af6bb674ea0c5524538259e6d6d98f78
@gaearon gaearon mentioned this pull request Mar 29, 2022
zhengjitf pushed a commit to zhengjitf/react that referenced this pull request Apr 15, 2022
nevilm-lt pushed a commit to nevilm-lt/react that referenced this pull request Apr 22, 2022
thiagojedi added a commit to thiagojedi/compat-alias-package that referenced this pull request Oct 4, 2022
So, there were a few issues with Node >17 and storybookjs (storybookjs/storybook#16623) that was causing errors on build, similarly to preactjs/preact#3745.

It was fixed in the same way by react: facebook/react#22954
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
4 participants