Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fork ReactSymbols #24484

Merged
merged 3 commits into from
May 3, 2022
Merged

Fork ReactSymbols #24484

merged 3 commits into from
May 3, 2022

Conversation

rickhanlonii
Copy link
Member

Overview

This should unblock DevTools while we land the Symbol polyfill for internal builds.

@rickhanlonii rickhanlonii requested review from lunaruan and acdlite May 3, 2022 18:11
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels May 3, 2022
@sizebot
Copy link

sizebot commented May 3, 2022

Comparing: 99eef9e...c6a4b18

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 131.58 kB 131.58 kB = 42.17 kB 42.17 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 136.82 kB 136.82 kB = 43.68 kB 43.68 kB
facebook-www/ReactDOM-prod.classic.js = 440.68 kB 440.68 kB = 80.33 kB 80.33 kB
facebook-www/ReactDOM-prod.modern.js = 425.89 kB 425.89 kB = 78.17 kB 78.17 kB
facebook-www/ReactDOMForked-prod.classic.js = 440.68 kB 440.68 kB = 80.33 kB 80.33 kB
facebook-react-native/react-is/cjs/ReactIs-dev.js +2.36% 7.53 kB 7.71 kB +4.62% 2.06 kB 2.15 kB
oss-stable-semver/react-is/cjs/react-is.development.js +2.28% 7.20 kB 7.36 kB +4.84% 1.92 kB 2.02 kB
oss-stable/react-is/cjs/react-is.development.js +2.28% 7.20 kB 7.36 kB +4.84% 1.92 kB 2.02 kB
oss-experimental/react-is/cjs/react-is.development.js +2.26% 7.22 kB 7.38 kB +4.82% 1.93 kB 2.02 kB
oss-stable-semver/react-is/umd/react-is.development.js +2.20% 7.74 kB 7.91 kB +4.74% 2.00 kB 2.10 kB
oss-stable/react-is/umd/react-is.development.js +2.20% 7.74 kB 7.91 kB +4.74% 2.00 kB 2.10 kB
oss-experimental/react-is/umd/react-is.development.js +2.18% 7.77 kB 7.94 kB +4.63% 2.01 kB 2.10 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-react-native/react-is/cjs/ReactIs-dev.js +2.36% 7.53 kB 7.71 kB +4.62% 2.06 kB 2.15 kB
oss-stable-semver/react-is/cjs/react-is.development.js +2.28% 7.20 kB 7.36 kB +4.84% 1.92 kB 2.02 kB
oss-stable/react-is/cjs/react-is.development.js +2.28% 7.20 kB 7.36 kB +4.84% 1.92 kB 2.02 kB
oss-experimental/react-is/cjs/react-is.development.js +2.26% 7.22 kB 7.38 kB +4.82% 1.93 kB 2.02 kB
oss-stable-semver/react-is/umd/react-is.development.js +2.20% 7.74 kB 7.91 kB +4.74% 2.00 kB 2.10 kB
oss-stable/react-is/umd/react-is.development.js +2.20% 7.74 kB 7.91 kB +4.74% 2.00 kB 2.10 kB
oss-experimental/react-is/umd/react-is.development.js +2.18% 7.77 kB 7.94 kB +4.63% 2.01 kB 2.10 kB
oss-experimental/jest-react/cjs/jest-react.development.js +1.80% 9.75 kB 9.93 kB +2.43% 3.37 kB 3.46 kB
oss-stable-semver/jest-react/cjs/jest-react.development.js +1.80% 9.75 kB 9.93 kB +2.43% 3.37 kB 3.46 kB
oss-stable/jest-react/cjs/jest-react.development.js +1.80% 9.75 kB 9.93 kB +2.43% 3.37 kB 3.46 kB
facebook-relay/flight/ReactFlightNativeRelayClient-dev.js +1.71% 10.41 kB 10.58 kB +2.73% 3.08 kB 3.16 kB
oss-experimental/react-client/cjs/react-client-flight.development.js +1.28% 13.64 kB 13.82 kB +1.93% 4.00 kB 4.07 kB
oss-stable-semver/react-client/cjs/react-client-flight.development.js +1.28% 13.64 kB 13.82 kB +1.93% 4.00 kB 4.07 kB
oss-stable/react-client/cjs/react-client-flight.development.js +1.28% 13.64 kB 13.82 kB +1.93% 4.00 kB 4.07 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack.development.js +1.08% 16.19 kB 16.36 kB +1.79% 4.63 kB 4.71 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack.development.js +1.08% 16.19 kB 16.36 kB +1.79% 4.63 kB 4.71 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack.development.js +1.08% 16.19 kB 16.36 kB +1.79% 4.63 kB 4.71 kB
oss-experimental/react-server-dom-webpack/umd/react-server-dom-webpack.development.js +1.04% 17.40 kB 17.58 kB +1.77% 4.76 kB 4.84 kB
oss-stable-semver/react-server-dom-webpack/umd/react-server-dom-webpack.development.js +1.04% 17.40 kB 17.58 kB +1.77% 4.76 kB 4.84 kB
oss-stable/react-server-dom-webpack/umd/react-server-dom-webpack.development.js +1.04% 17.40 kB 17.58 kB +1.77% 4.76 kB 4.84 kB
oss-experimental/react-noop-renderer/cjs/react-noop-renderer.development.js +0.51% 34.27 kB 34.45 kB +0.98% 7.68 kB 7.75 kB
oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer.development.js +0.51% 34.27 kB 34.45 kB +0.98% 7.68 kB 7.75 kB
oss-stable/react-noop-renderer/cjs/react-noop-renderer.development.js +0.51% 34.27 kB 34.45 kB +0.98% 7.68 kB 7.75 kB
oss-experimental/react-noop-renderer/cjs/react-noop-renderer-persistent.development.js +0.51% 34.40 kB 34.58 kB +0.99% 7.70 kB 7.77 kB
oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-persistent.development.js +0.51% 34.40 kB 34.58 kB +0.99% 7.70 kB 7.77 kB
oss-stable/react-noop-renderer/cjs/react-noop-renderer-persistent.development.js +0.51% 34.40 kB 34.58 kB +0.99% 7.70 kB 7.77 kB
facebook-react-native/react/cjs/JSXDEVRuntime-dev.js +0.50% 35.81 kB 35.99 kB +0.72% 10.39 kB 10.46 kB
facebook-react-native/react/cjs/JSXRuntime-dev.js +0.49% 36.41 kB 36.59 kB +0.71% 10.56 kB 10.63 kB
facebook-relay/flight/ReactFlightNativeRelayServer-dev.js +0.46% 38.68 kB 38.86 kB +0.85% 9.80 kB 9.88 kB
oss-experimental/react-server/cjs/react-server-flight.development.js +0.44% 38.31 kB 38.48 kB +0.88% 9.69 kB 9.78 kB
oss-stable-semver/react-server/cjs/react-server-flight.development.js +0.44% 38.31 kB 38.48 kB +0.88% 9.69 kB 9.78 kB
oss-stable/react-server/cjs/react-server-flight.development.js +0.44% 38.31 kB 38.48 kB +0.88% 9.69 kB 9.78 kB
oss-stable-semver/react/cjs/react-jsx-dev-runtime.development.js +0.40% 40.98 kB 41.15 kB +0.66% 11.98 kB 12.06 kB
oss-stable/react/cjs/react-jsx-dev-runtime.development.js +0.40% 40.98 kB 41.15 kB +0.66% 11.98 kB 12.06 kB
oss-stable-semver/react/cjs/react-jsx-runtime.development.js +0.39% 41.58 kB 41.75 kB +0.66% 12.16 kB 12.24 kB
oss-stable/react/cjs/react-jsx-runtime.development.js +0.39% 41.58 kB 41.75 kB +0.66% 12.16 kB 12.24 kB
oss-experimental/react/cjs/react-jsx-dev-runtime.development.js +0.39% 41.32 kB 41.48 kB +0.63% 12.05 kB 12.13 kB
oss-experimental/react/cjs/react-jsx-runtime.development.js +0.39% 41.91 kB 42.08 kB +0.64% 12.23 kB 12.30 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-writer.browser.development.server.js +0.28% 60.99 kB 61.16 kB +0.49% 15.78 kB 15.85 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-writer.browser.development.server.js +0.28% 60.99 kB 61.16 kB +0.49% 15.78 kB 15.85 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-writer.browser.development.server.js +0.28% 61.05 kB 61.22 kB +0.49% 15.80 kB 15.88 kB
oss-stable-semver/react-server-dom-webpack/umd/react-server-dom-webpack-writer.browser.development.server.js +0.27% 64.14 kB 64.32 kB +0.47% 16.00 kB 16.08 kB
oss-stable/react-server-dom-webpack/umd/react-server-dom-webpack-writer.browser.development.server.js +0.27% 64.14 kB 64.32 kB +0.47% 16.00 kB 16.08 kB
oss-experimental/react-server-dom-webpack/umd/react-server-dom-webpack-writer.browser.development.server.js +0.27% 64.20 kB 64.38 kB +0.49% 16.02 kB 16.10 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-writer.node.development.server.js +0.27% 62.77 kB 62.94 kB +0.47% 15.97 kB 16.05 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-writer.node.development.server.js +0.27% 62.77 kB 62.94 kB +0.47% 15.97 kB 16.05 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-writer.node.development.server.js +0.27% 62.82 kB 62.99 kB +0.48% 16.00 kB 16.07 kB
oss-experimental/react/cjs/react.shared-subset.development.js +0.22% 74.63 kB 74.79 kB +0.35% 20.33 kB 20.40 kB

Generated by 🚫 dangerJS against c6a4b18

@rickhanlonii
Copy link
Member Author

I manually confirmed that sizebot is wrong.

@rickhanlonii rickhanlonii merged commit 6cbf0f7 into facebook:main May 3, 2022
@rickhanlonii rickhanlonii deleted the rh-fork-symbols branch May 3, 2022 21:12
facebook-github-bot pushed a commit to facebook/react-native that referenced this pull request Jun 6, 2022
Summary:
This sync includes the following changes:
- **[dd4950c90](facebook/react@dd4950c90 )**: [Flight] Implement useId hook ([#24172](facebook/react#24172)) //<Josh Story>//
- **[26a5b3c7f](facebook/react@26a5b3c7f )**: Explicitly set `highWaterMark` to 0 for `ReadableStream` ([#24641](facebook/react#24641)) //<Josh Larson>//
- **[aec575914](facebook/react@aec575914 )**: [Fizz] Send errors down to client ([#24551](facebook/react#24551)) //<Josh Story>//
- **[a2766387e](facebook/react@a2766387e )**: [Fizz] Improve text separator byte efficiency ([#24630](facebook/react#24630)) //<Josh Story>//
- **[f7860538a](facebook/react@f7860538a )**: Fix typo in useSyncExternalStore main entry point error ([#24631](facebook/react#24631)) //<François Chalifour>//
- **[1bed20731](facebook/react@1bed20731 )**: Add a module map option to the Webpack Flight Client ([#24629](facebook/react#24629)) //<Sebastian Markbåge>//
- **[b2763d3ea](facebook/react@b2763d3ea )**: Move hydration code out of normal Suspense path ([#24532](facebook/react#24532)) //<Andrew Clark>//
- **[357a61324](facebook/react@357a61324 )**: [DevTools][Transition Tracing] Added support for Suspense Boundaries ([#23365](facebook/react#23365)) //<Luna Ruan>//
- **[2c8a1452b](facebook/react@2c8a1452b )**: Fix ignored setState in Safari when iframe is touched ([#24459](facebook/react#24459)) //<dan>//
- **[62662633d](facebook/react@62662633d )**: Remove enableFlipOffscreenUnhideOrder ([#24545](facebook/react#24545)) //<Ricky>//
- **[34da5aa69](facebook/react@34da5aa69 )**: Only treat updates to lazy as a new mount in legacy mode ([#24530](facebook/react#24530)) //<Ricky>//
- **[46a6d77e3](facebook/react@46a6d77e3 )**: Unify JSResourceReference Interfaces ([#24507](facebook/react#24507)) //<Timothy Yung>//
- **[6cbf0f7fa](facebook/react@6cbf0f7fa )**: Fork ReactSymbols ([#24484](facebook/react#24484)) //<Ricky>//
- **[a10a9a6b5](facebook/react@a10a9a6b5 )**: Add test for hiding children after layout destroy ([#24483](facebook/react#24483)) //<Ricky>//
- **[b4eb0ad71](facebook/react@b4eb0ad71 )**: Do not replay erroring beginWork with invokeGuardedCallback when suspended or previously errored ([#24480](facebook/react#24480)) //<Josh Story>//
- **[99eef9e2d](facebook/react@99eef9e2d )**: Hide children of Offscreen after destroy effects ([#24446](facebook/react#24446)) //<Ricky>//
- **[ce1386028](facebook/react@ce1386028 )**: Remove enablePersistentOffscreenHostContainer flag ([#24460](facebook/react#24460)) //<Andrew Clark>//
- **[72b7462fe](facebook/react@72b7462fe )**: Bump local package.json versions for 18.1 release ([#24447](facebook/react#24447)) //<Andrew Clark>//
- **[22edb9f77](facebook/react@22edb9f77 )**: React `version` field should match package.json ([#24445](facebook/react#24445)) //<Andrew Clark>//
- **[6bf3deef5](facebook/react@6bf3deef5 )**: Upgrade react-shallow-renderer to support react 18 ([#24442](facebook/react#24442)) //<Michael サイトー 中村 Bashurov>//

Changelog:
[General][Changed] - React Native sync for revisions bd4784c...d300ceb

jest_e2e[run_all_tests]

Reviewed By: cortinico, kacieb

Differential Revision: D36874368

fbshipit-source-id: c0ee015f4ef2fa56e57f7a1f6bc37dd05c949877
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants