Skip to content

feat:-added tests for more coverage in reactDom-input and reactText-area #27796

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Dec 8, 2023

Conversation

Biki-das
Copy link
Contributor

@Biki-das Biki-das commented Dec 5, 2023

Small test similar to few tests added in #27740 , the reactDom-input error message was just modified to match the error message, and the reactDomTextarea-test.js has tests added to ensure more coverage.

@Biki-das
Copy link
Contributor Author

Biki-das commented Dec 5, 2023

cc @hoxyq

@Biki-das Biki-das changed the title feat: -added tests for more coverage in reactDom-input and reactText-area feat:-added tests for more coverage in reactDom-input and reactText-area Dec 5, 2023
@react-sizebot
Copy link

react-sizebot commented Dec 5, 2023

Comparing: c29ca23...d795958

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 175.90 kB 175.90 kB = 54.75 kB 54.76 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 177.97 kB 177.97 kB = 55.39 kB 55.39 kB
facebook-www/ReactDOM-prod.classic.js = 569.81 kB 569.81 kB = 100.29 kB 100.29 kB
facebook-www/ReactDOM-prod.modern.js = 553.67 kB 553.67 kB = 97.38 kB 97.38 kB
test_utils/ReactAllWarnings.js Deleted 67.17 kB 0.00 kB Deleted 16.35 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 67.17 kB 0.00 kB Deleted 16.35 kB 0.00 kB

Generated by 🚫 dangerJS against d795958

@hoxyq hoxyq merged commit a3aae7f into facebook:main Dec 8, 2023
@Biki-das Biki-das deleted the dom-test branch December 8, 2023 18:51
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
…rea (facebook#27796)

Small test similar to few tests added in facebook#27740 , the `reactDom-input`
error message was just modified to match the error message, and the
`reactDomTextarea-test.js` has tests added to ensure more coverage.
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants